Re: [PATCH i18n] update Japanese translation

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

ribbon <ribbon@skrbn.sakura.ne.jp> writes:

Thanks for resubmitting this patch. For future contributions, could you
please add a signed-by trailer to the commit message? This can be done
either with the `-s` (git commit -s) flag or manually writing it as part
of the message.

Some comments below.

> This is Japanese translation update.
>
> --- ja.po.old	2026-06-02 21:33:30.559160599 +0900
> +++ ja.po	2026-06-02 22:54:17.720670152 +0900
> [..]
>  #: proxmox-datacenter-manager/ui/src/dashboard/map.rs:256
> -#, fuzzy
>  msgid "1 Node"
>  msgid_plural "{0} Nodes"
> -msgstr[0] "ノード"
> +msgstr[0] "1ノード"

The translation should be contain the variable {0}, otherwise the
translation would read "1ノード" regardless of the number of nodes.

>
>  [..]
>
>  #. TRANSLATORS: For example "resource on Remote 'HAL 9000'"
>  #: proxmox-datacenter-manager/ui/src/dashboard/top_entities.rs:250
> @@ -21984,10 +21868,9 @@
>  #. magnitude so typing in the filter doesn't reflow the toolbar
>  #: proxmox-datacenter-manager/ui/src/guests.rs:393
>  #: proxmox-datacenter-manager/ui/src/guests.rs:401
> -#, fuzzy
>  msgid "{0} out of {1} Guest"
>  msgid_plural "{0} out of {1} Guests"
> -msgstr[0] "{1}コアの {0}"
> +msgstr[0] "{0} out of {1} Guests"

This was translated to English, is this intentional?

>  [..]
> 
> -#~ msgid "{0}, Group: {1}"
> -#~ msgstr "{0}, グループ: {1}"

-- 
Maximiliano