From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id EA5911FF13B
	for <inbox@lore.proxmox.com>; Wed, 03 Jun 2026 09:10:17 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id BF616378F9;
	Wed,  3 Jun 2026 09:10:17 +0200 (CEST)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: ribbon <ribbon@skrbn.sakura.ne.jp>
Subject: Re: [PATCH i18n] update Japanese translation
In-Reply-To: <ah7h28zcWSGXzZDD@ns.ribbon.or.jp> (ribbon@skrbn.sakura.ne.jp's
	message of "Tue, 2 Jun 2026 22:59:55 +0900")
References: <ah7h28zcWSGXzZDD@ns.ribbon.or.jp>
User-Agent: mu4e 1.12.9; emacs 30.1
Date: Wed, 03 Jun 2026 09:10:10 +0200
Message-ID: <s8oa4tc5cbx.fsf@toolbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1780470574197
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.127 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	WEIRD_PORT              0.001 Uses non-standard port number for HTTP
Message-ID-Hash: D3EUZQTEYWQ2BCRALRTGRM74BEJ453IU
X-Message-ID-Hash: D3EUZQTEYWQ2BCRALRTGRM74BEJ453IU
X-MailFrom: m.sandoval@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

ribbon <ribbon@skrbn.sakura.ne.jp> writes:

Thanks for resubmitting this patch. For future contributions, could you
please add a signed-by trailer to the commit message? This can be done
either with the `-s` (git commit -s) flag or manually writing it as part
of the message.

Some comments below.

> This is Japanese translation update.
>
> --- ja.po.old	2026-06-02 21:33:30.559160599 +0900
> +++ ja.po	2026-06-02 22:54:17.720670152 +0900
> [..]
>  #: proxmox-datacenter-manager/ui/src/dashboard/map.rs:256
> -#, fuzzy
>  msgid "1 Node"
>  msgid_plural "{0} Nodes"
> -msgstr[0] "=E3=83=8E=E3=83=BC=E3=83=89"
> +msgstr[0] "1=E3=83=8E=E3=83=BC=E3=83=89"

The translation should be contain the variable {0}, otherwise the
translation would read "1=E3=83=8E=E3=83=BC=E3=83=89" regardless of the num=
ber of nodes.

>
>  [..]
>
>  #. TRANSLATORS: For example "resource on Remote 'HAL 9000'"
>  #: proxmox-datacenter-manager/ui/src/dashboard/top_entities.rs:250
> @@ -21984,10 +21868,9 @@
>  #. magnitude so typing in the filter doesn't reflow the toolbar
>  #: proxmox-datacenter-manager/ui/src/guests.rs:393
>  #: proxmox-datacenter-manager/ui/src/guests.rs:401
> -#, fuzzy
>  msgid "{0} out of {1} Guest"
>  msgid_plural "{0} out of {1} Guests"
> -msgstr[0] "{1}=E3=82=B3=E3=82=A2=E3=81=AE {0}"
> +msgstr[0] "{0} out of {1} Guests"

This was translated to English, is this intentional?

>  [..]
>=20
> -#~ msgid "{0}, Group: {1}"
> -#~ msgstr "{0}, =E3=82=B0=E3=83=AB=E3=83=BC=E3=83=97: {1}"

--=20
Maximiliano