all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com, ribbon <ribbon@skrbn.sakura.ne.jp>
Subject: Re: [PATCH i18n] update Japanese translation(20260612)
Date: Mon, 15 Jun 2026 09:09:23 +0200	[thread overview]
Message-ID: <178150665333.47255.3942758648334036812.b4-ty@proxmox.com> (raw)
In-Reply-To: <aizThUwwuExU7fWf@ns.ribbon.or.jp>


On Sat, 13 Jun 2026 12:50:29 +0900, ribbon wrote:
> This is Japanese translation update (20260612).
> 
> On Wed, Jun 03, 2026 at 09:10:10AM +0200, Maximiliano Sandoval wrote:
> 
> > Thanks for resubmitting this patch. For future contributions, could you
> > please add a signed-by trailer to the commit message? This can be done
> > either with the `-s` (git commit -s) flag or manually writing it as part
> > of the message.

Please take a look at
https://lore.proxmox.com/all/20260612081419.38750-1-s.sterz@proxmox.com/T/#u for
example. Adding the signed-off trailer consists writing "Signed-off-by: ribbon
<ribbon@skrbn.sakura.ne.jp>" as plain-tex in the email's body.

The emacs package "magit" has a git-commit-insert-trailer method that can be
used to insert trailers.

Regarding the translations themselves, Japanese has a single plural form so I
removed all the lines `msgstr[1] "..."` for example the change:

> @@ -100,26 +100,29 @@
> #: pve-yew-mobile-gui/src/pages/page_dashboard.rs:135
> msgid "1 CPU"
> msgid_plural "{n} CPUs"
> -msgstr[0] "{n} CPU"
> +msgstr[0] "1 CPU"
> +msgstr[1] "{n} CPU"

was fixed to:

```
#: pve-yew-mobile-gui/src/pages/page_dashboard.rs:135
msgid "1 CPU"
msgid_plural "{n} CPUs"
msgstr[0] "{n} CPUs"
```

another example:
```
msgid "1 Socket"
msgid_plural "{n} Sockets"
msgstr[0] "{n}ソケット"
```

Please update your local copy based on the latest commit.

Applied, thanks!

[1/1] update Japanese translation(20260612)
      (no commit info)

Best regards,
-- 
Maximiliano Sandoval <m.sandoval@proxmox.com>




  reply	other threads:[~2026-06-15  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 13:59 [PATCH i18n] update Japanese translation ribbon
2026-06-03  7:10 ` Maximiliano Sandoval
2026-06-13  3:50   ` [PATCH i18n] update Japanese translation(20260612) ribbon
2026-06-15  7:09     ` Maximiliano Sandoval [this message]
2026-06-03  7:44 ` [PATCH i18n] update Japanese translation Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178150665333.47255.3942758648334036812.b4-ty@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=ribbon@skrbn.sakura.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal