From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 21/26] ui: fabrics: interface: make ipv4/6 support generic over edit panels
Date: Mon, 4 May 2026 18:11:04 +0200 [thread overview]
Message-ID: <20260504161115.408970-22-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20260504161115.408970-1-s.hanreich@proxmox.com>
From: Christoph Heiss <c.heiss@proxmox.com>
This allows selectively enabling IPv4/6 in the child components,
without having to re-define the respective fields in every child
component. A later commit will introduce the Wireguard fabric, which
will have neither a IPv4 nor IPv6 prefix for now, so the option to
exclude those fields will be used there as well.
Co-authored-by: Stefan Hanreich <s.hanreich@proxmox.com?
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
www/manager6/sdn/fabrics/InterfacePanel.js | 18 ++++++++++++++++++
.../sdn/fabrics/openfabric/InterfacePanel.js | 13 -------------
.../sdn/fabrics/ospf/InterfacePanel.js | 2 ++
3 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
index f75f1acd2..ab2162b1e 100644
--- a/www/manager6/sdn/fabrics/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/InterfacePanel.js
@@ -6,6 +6,8 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
nodeInterfaces: {},
+ hasIpv6Support: true,
+
selModel: {
mode: 'SIMPLE',
type: 'checkboxmodel',
@@ -106,6 +108,22 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
initComponent: function () {
let me = this;
+ if (me.hasIpv6Support) {
+ me.commonColumns.push({
+ text: gettext('IPv6'),
+ xtype: 'widgetcolumn',
+ dataIndex: 'ip6',
+ flex: 1,
+ widget: {
+ xtype: 'proxmoxtextfield',
+ isFormField: false,
+ bind: {
+ disabled: '{record.isDisabled}',
+ },
+ },
+ });
+ }
+
Ext.apply(me, {
store: Ext.create('Ext.data.Store', {
model: 'Pve.sdn.Interface',
diff --git a/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js b/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js
index f23b889b4..19438bf5f 100644
--- a/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/openfabric/InterfacePanel.js
@@ -2,19 +2,6 @@ Ext.define('PVE.sdn.Fabric.OpenFabric.InterfacePanel', {
extend: 'PVE.sdn.Fabric.InterfacePanel',
additionalColumns: [
- {
- text: gettext('IPv6'),
- xtype: 'widgetcolumn',
- dataIndex: 'ip6',
- flex: 1,
- widget: {
- xtype: 'proxmoxtextfield',
- isFormField: false,
- bind: {
- disabled: '{record.isDisabled}',
- },
- },
- },
{
text: gettext('Hello Multiplier'),
xtype: 'widgetcolumn',
diff --git a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
index 29f0502fa..b521b1a22 100644
--- a/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/ospf/InterfacePanel.js
@@ -1,3 +1,5 @@
Ext.define('PVE.sdn.Fabric.Ospf.InterfacePanel', {
extend: 'PVE.sdn.Fabric.InterfacePanel',
+
+ hasIpv6Support: false,
});
--
2.47.3
next prev parent reply other threads:[~2026-05-04 16:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 16:10 [PATCH manager/network/proxmox{,-ve-rs,-perl-rs} v3 00/26] Add WireGuard as protocol to SDN fabrics Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox v3 01/26] wireguard: skip serializing preshared_key if unset Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox v3 02/26] wireguard: implement ApiType for endpoints and hostnames Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 03/26] sdn-types: add wireguard-specific PersistentKeepalive api type Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 04/26] ve-config: fabrics: split interface name regex into two parts Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 05/26] ve-config: fabric: refactor fabric config entry impl using macro Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 06/26] ve-config: fabrics: add protocol-specific properties for wireguard Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 07/26] ve-config: sdn: fabrics: add wireguard to the fabric config Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 08/26] ve-config: fabrics: wireguard add validation for wireguard config Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 09/26] ve-config: fabrics: implement wireguard config generation Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-perl-rs v3 10/26] pve-rs: fabrics: wireguard: generate ifupdown2 configuration Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-perl-rs v3 11/26] pve-rs: fabrics: add helpers for parsing interface property strings Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-network v3 12/26] sdn: add wireguard helper module Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-network v3 13/26] fabrics: wireguard: add schema definitions for wireguard Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-network v3 14/26] fabrics: wireguard: implement wireguard key auto-generation Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-manager v3 15/26] network: sdn: generate wireguard configuration on apply Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-manager v3 16/26] ui: fix parsing of property-strings when values contain = Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 17/26] ui: fabrics: i18n: make node loading string translatable Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 18/26] ui: fabrics: split node selector creation and config Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 19/26] ui: fabrics: edit: make ipv4/6 support generic over fabric panels Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 20/26] ui: fabrics: node: make ipv4/6 support generic over edit panels Stefan Hanreich
2026-05-04 16:11 ` Stefan Hanreich [this message]
2026-05-04 16:11 ` [PATCH pve-manager v3 22/26] ui: fabrics: wireguard: add interface edit panel Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 23/26] ui: fabrics: wireguard: add node " Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 24/26] ui: fabrics: wireguard: add fabric " Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 25/26] ui: fabrics: hook up wireguard components Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 26/26] fabrics: node edit: add option to include wireguard interfaces Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504161115.408970-22-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox