public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v3 26/26] fabrics: node edit: add option to include wireguard interfaces
Date: Mon,  4 May 2026 18:11:09 +0200	[thread overview]
Message-ID: <20260504161115.408970-27-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20260504161115.408970-1-s.hanreich@proxmox.com>

Because Wireguard interfaces are generated in a file separate from
/e/n/i, they do not show up automatically in the PVE interface
selector. Since they can be used without issue in some fabrics
(everything layer 3 and above), add the option to the node edit
component to include wireguard interfaces in the interface selection
of the node edit window as well.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 www/manager6/sdn/fabrics/NodeEdit.js      | 44 ++++++++++++++++++++---
 www/manager6/sdn/fabrics/ospf/NodeEdit.js |  1 +
 2 files changed, 40 insertions(+), 5 deletions(-)

diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js
index 55dce3043..4b3967a17 100644
--- a/www/manager6/sdn/fabrics/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/NodeEdit.js
@@ -30,6 +30,7 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', {
     additionalItems: [],
 
     addAnotherCallback: undefined,
+    includeWireguardInterfaces: false,
 
     initComponent: function () {
         let me = this;
@@ -127,17 +128,50 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', {
     loadNodeInterfaces: async function () {
         let me = this;
 
-        let req = await Proxmox.Async.api2({
-            url: `/api2/extjs/nodes/${me.nodeId}/network`,
-            method: 'GET',
-        });
+        let requests = [
+            Proxmox.Async.api2({
+                url: `/api2/extjs/nodes/${me.nodeId}/network`,
+                method: 'GET',
+            }),
+        ];
+
+        if (me.includeWireguardInterfaces) {
+            requests.push(
+                Proxmox.Async.api2({
+                    url: `/api2/extjs/cluster/sdn/fabrics/node/`,
+                    method: 'GET',
+                }),
+            );
+        }
 
-        return req.result.data.map((iface) => ({
+        let result = await Promise.all(requests);
+
+        let interfaces = result[0].result.data.map((iface) => ({
             name: iface.iface,
             type: iface.type,
             ip: iface.cidr,
             ipv6: iface.cidr6,
         }));
+
+        if (me.includeWireguardInterfaces) {
+            let wireguardNodes = result[1].result.data
+                .filter((node) => {
+                    return node.node_id === me.nodeId && node.protocol === 'wireguard' ;
+                });
+
+            for (const node of wireguardNodes) {
+                for (const ifacePropertyString of node.interfaces) {
+                    let iface = PVE.Parser.parsePropertyString(ifacePropertyString);
+
+                    interfaces.push({
+                        name: iface.name,
+                        type: 'wireguard',
+                    });
+                }
+            }
+        }
+
+        return interfaces;
     },
 
     load: function () {
diff --git a/www/manager6/sdn/fabrics/ospf/NodeEdit.js b/www/manager6/sdn/fabrics/ospf/NodeEdit.js
index 370aee191..bf96ee95f 100644
--- a/www/manager6/sdn/fabrics/ospf/NodeEdit.js
+++ b/www/manager6/sdn/fabrics/ospf/NodeEdit.js
@@ -3,6 +3,7 @@ Ext.define('PVE.sdn.Fabric.Ospf.Node.Edit', {
     protocol: 'ospf',
 
     hasIpv6Support: false,
+    includeWireguardInterfaces: true,
 
     extraRequestParams: {
         protocol: 'ospf',
-- 
2.47.3





      parent reply	other threads:[~2026-05-04 16:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 16:10 [PATCH manager/network/proxmox{,-ve-rs,-perl-rs} v3 00/26] Add WireGuard as protocol to SDN fabrics Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox v3 01/26] wireguard: skip serializing preshared_key if unset Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox v3 02/26] wireguard: implement ApiType for endpoints and hostnames Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 03/26] sdn-types: add wireguard-specific PersistentKeepalive api type Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 04/26] ve-config: fabrics: split interface name regex into two parts Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 05/26] ve-config: fabric: refactor fabric config entry impl using macro Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 06/26] ve-config: fabrics: add protocol-specific properties for wireguard Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 07/26] ve-config: sdn: fabrics: add wireguard to the fabric config Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 08/26] ve-config: fabrics: wireguard add validation for wireguard config Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-ve-rs v3 09/26] ve-config: fabrics: implement wireguard config generation Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-perl-rs v3 10/26] pve-rs: fabrics: wireguard: generate ifupdown2 configuration Stefan Hanreich
2026-05-04 16:10 ` [PATCH proxmox-perl-rs v3 11/26] pve-rs: fabrics: add helpers for parsing interface property strings Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-network v3 12/26] sdn: add wireguard helper module Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-network v3 13/26] fabrics: wireguard: add schema definitions for wireguard Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-network v3 14/26] fabrics: wireguard: implement wireguard key auto-generation Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-manager v3 15/26] network: sdn: generate wireguard configuration on apply Stefan Hanreich
2026-05-04 16:10 ` [PATCH pve-manager v3 16/26] ui: fix parsing of property-strings when values contain = Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 17/26] ui: fabrics: i18n: make node loading string translatable Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 18/26] ui: fabrics: split node selector creation and config Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 19/26] ui: fabrics: edit: make ipv4/6 support generic over fabric panels Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 20/26] ui: fabrics: node: make ipv4/6 support generic over edit panels Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 21/26] ui: fabrics: interface: " Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 22/26] ui: fabrics: wireguard: add interface edit panel Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 23/26] ui: fabrics: wireguard: add node " Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 24/26] ui: fabrics: wireguard: add fabric " Stefan Hanreich
2026-05-04 16:11 ` [PATCH pve-manager v3 25/26] ui: fabrics: hook up wireguard components Stefan Hanreich
2026-05-04 16:11 ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504161115.408970-27-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal