Re: [PATCH proxmox-i18n v2 00/11] Makefile simplifications and improvements

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote:
> The main difference in behavior is that we add --previous to the msgmerge
> command used to update the PO files. This can add some extra information to
> translations, which can make it easier to determine whether the previous
> translation is still valid or what kind of modifications it needs.
>
> See individual commits and their notes.
>
> Additionally:
>  - there are a couple of cleanups
>  - we move the LINGUAS to a dedicated file
>  - check LINGUAS and add languages to it on the init-%.po target
>  - split the do_update target on a per-language basis
>
> Differences from v1:
>  - Move LINGUAS to a dedicated file
>  - split the do_update target on a per-language basis
>
> Maximiliano Sandoval (11):
>   make: catalog-%.mo: explicitly set template file
>   make: simplify msgmerge commands
>   make: clean: remove *.mo files
>   make: use long options for msgmerge and msginit
>   make: do_update: add --update for msgmerge
>   make: do_update: add --previous flag to msgmerge
>   gitignore: remove proxmox-datacenter-manager.pot
>   make: move linguas to a file
>   make: add linguas checks
>   make: init-%.po: add language to linguas
>   make: add targets to update specific PO files
>
>  .gitignore |  1 -
>  LINGUAS    | 32 ++++++++++++++++++++++++
>  Makefile   | 72 ++++++++++++++++++++----------------------------------
>  3 files changed, 59 insertions(+), 46 deletions(-)
>  create mode 100644 LINGUAS

gave the targets here a quick spin and it looked alright to me. i left a
few small comments on style and make file structure, but nothing to
major so consider this:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>