Re: [PATCH proxmox-i18n v2 01/11] make: catalog-%.mo: explicitly set template file

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote:
> msgmerge takes exactly two arguments. Fixes a regression from aacd4e7a.

tiny nit: quoting the commit message here might be nice, but that's not
really much of a problem. the commit message was this btw:

> buildsys: use combined message catalogue for now

>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 86f81e9b..b233828b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -125,8 +125,8 @@ pve-lang-%.js: %.po
>  pbs-lang-%.js: %.po
>  	./po2js.pl -t pbs -v "$(DEB_VERSION)" -o pbs-lang-$*.js $?
>
> -catalog-%.mo: %.po
> -	msgmerge $^ | msgattrib --no-fuzzy --no-obsolete | msgfmt --verbose --output-file $@ $<;
> +catalog-%.mo: %.po messages.pot
> +	msgmerge $*.po messages.pot | msgattrib --no-fuzzy --no-obsolete | msgfmt --verbose --output-file $@ $<;

imo `msmerge $< message.po |...` would convey your intend here a little
bit more clearly. `$<` being the first full prerequisite. `$*` as the
target file stems is imo a bit harder to understand personally. but as
this is more of a personal taste issue, it shouldn't be blocker imo.

since you use that throughout, it won't mention it everytime.

>
>  .INTERMEDIATE: pve-yew-mobile-all.pot
>  pve-yew-mobile-all.pot: pve-yew-mobile-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot