Re: [PATCH proxmox-i18n v2 02/11] make: simplify msgmerge commands

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote:
> msgmerge has a --for-msgfmt which produces the same output ass filtering via

nit: slightly unfortunate typo

> msgattrib. This removes the need for temporal files.
>
> Some differences are that --for-msgfmt will also strip file location and
> comments which do not serve any purpose when generating .mo files.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  Makefile | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b233828b..dcd742ea 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -126,25 +126,21 @@ pbs-lang-%.js: %.po
>  	./po2js.pl -t pbs -v "$(DEB_VERSION)" -o pbs-lang-$*.js $?
>
>  catalog-%.mo: %.po messages.pot
> -	msgmerge $*.po messages.pot | msgattrib --no-fuzzy --no-obsolete | msgfmt --verbose --output-file $@ $<;
> +	msgmerge $*.po messages.pot --for-msgfmt | msgfmt --verbose --output-file $@ -
>
>  .INTERMEDIATE: pve-yew-mobile-all.pot
>  pve-yew-mobile-all.pot: pve-yew-mobile-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot
>  	xgettext $^ --output $@
>
>  pve-yew-mobile-catalog-%.mo: %.po pve-yew-mobile-all.pot
> -	msgmerge $*.po pve-yew-mobile-all.pot| msgattrib --no-fuzzy --no-obsolete > $@.tmp
> -	msgfmt --verbose --output-file $@ $@.tmp;
> -	rm -rf  $@.tmp
> +	msgmerge $*.po pve-yew-mobile-all.pot --for-msgfmt | msgfmt --verbose --output-file $@ -
>
>  .INTERMEDIATE: pmg-yew-quarantine-all.pot
>  pmg-yew-quarantine-all.pot: pmg-yew-quarantine-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot
>  	xgettext $^ --output $@
>
>  pmg-yew-quarantine-catalog-%.mo: %.po pmg-yew-quarantine-all.pot
> -	msgmerge $*.po pmg-yew-quarantine-all.pot| msgattrib --no-fuzzy --no-obsolete > $@.tmp
> -	msgfmt --verbose --output-file $@ $@.tmp;
> -	rm -rf  $@.tmp
> +	msgmerge $*.po pmg-yew-quarantine-all.pot --for-msgfmt | msgfmt --verbose --output-file $@ -
>
>  # parameter 1 is the name
>  # parameter 2 is the directory