Re: [PATCH proxmox-i18n v2 09/11] make: add linguas checks

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote:
> Cross-references the list of languages in LINGUAS and the *.po files.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> Notes:
>     This should be equivalent to the less-verbose:
>
>         test "$(ls *.po | sed 's/.po//')" = "$(cat LINGUAS)"
>
>     but easier to understand why it fails on failure.
>
>  Makefile | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ceac4eab..3dd30401 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -202,5 +202,19 @@ upload: upload-pve upload-pmg upload-pbs upload-pdm
>  check-%: %.po
>  	msgfmt --check $*.po
>
> +.PHONY: check-linguas
> +check-linguas:
> +	sort --check --uniq LINGUAS
> +	set -e; for lang in $(LINGUAS); do \
> +	    echo "checking if $$lang.po exists"; \
> +	    test -f $$lang.po; \
> +	done

isn't this check covered by the specific `check-${langcode}` checks?
make will just fail if a prerequisite isn't present and there is no
target to produce it. so here removing a .po file will make the
accompanying check-${langcode} fail as there is no target to make it.

> +	set -e; for lang in $(shell ls *.po | sed 's/\.po//'); do \
> +	    echo "checking if $$lang is in LINGUAS"; \
> +	    grep --quiet --line-regexp $$lang LINGUAS; \
> +	done
> +
>  .PHONY: check
> -check: $(addprefix check-, $(LINGUAS))
> +check:
> +	$(MAKE) $(addprefix check-, $(LINGUAS))
> +	$(MAKE) check-linguas

any reason you do a second invocation of make here instead of sticking
to make's prerequisite mechanism? iirc the latter has the upside of
being more nicely parallelizable with `-j`