Re: [PATCH proxmox-i18n v2 04/11] make: use long options for msgmerge and msginit

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri Jul 24, 2026 at 3:06 PM CEST, Shannon Sterz wrote:
> On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote:
>> For improved readability and being consisten with the other commands.
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>>  Makefile | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 1873de31..77fd60a0 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -189,7 +189,7 @@ update_pot: submodule
>>  do_update:
>>  	$(MAKE) update_pot
>>  	$(MAKE) messages.pot
>> -	for i in $(LINGUAS); do echo -n "$$i: "; msgmerge -s -v $$i.po messages.pot >$$i.po.tmp && mv $$i.po.tmp $$i.po; done;
>> +	for i in $(LINGUAS); do echo -n "$$i: "; msgmerge --sort-output --verbose $$i.po messages.pot >$$i.po.tmp && mv $$i.po.tmp $$i.po; done;
>
> small question since you are
>

to complete my thought here: `--sort-output` is deprecated (according to
`man 1 msgmerge`). since you are touching this code already, maybe we
want to switch to `--sort-by-file` or stop sorting all together?

>>
>>  update:
>>  	git submodule foreach 'git pull --ff-only origin master'
>> @@ -199,7 +199,7 @@ stats:
>>  	@for i in $(LINGUAS); do echo -n "$$i: "; msgfmt --statistics -o /dev/null $$i.po; done
>>
>>  init-%.po: messages.pot
>> -	msginit -i $^ -l $^ -o $*.po --no-translator
>> +	msginit --input $^ --locale $^ --output-file $*.po --no-translator
>>
>>  .INTERMEDIATE: messages.pot
>>  messages.pot: proxmox-widget-toolkit.pot proxmox-mailgateway.pot pve-manager.pot proxmox-backup.pot proxmox-datacenter-manager-ui.pot pve-yew-mobile-gui.pot pmg-yew-quarantine-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot