From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-i18n v2 04/11] make: use long options for msgmerge and msginit
Date: Fri, 24 Jul 2026 15:06:24 +0200 [thread overview]
Message-ID: <DK6TO6766HRY.1NQ4RWYQMFIE7@proxmox.com> (raw)
In-Reply-To: <20260724111257.325867-5-m.sandoval@proxmox.com>
On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote:
> For improved readability and being consisten with the other commands.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1873de31..77fd60a0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -189,7 +189,7 @@ update_pot: submodule
> do_update:
> $(MAKE) update_pot
> $(MAKE) messages.pot
> - for i in $(LINGUAS); do echo -n "$$i: "; msgmerge -s -v $$i.po messages.pot >$$i.po.tmp && mv $$i.po.tmp $$i.po; done;
> + for i in $(LINGUAS); do echo -n "$$i: "; msgmerge --sort-output --verbose $$i.po messages.pot >$$i.po.tmp && mv $$i.po.tmp $$i.po; done;
small question since you are
>
> update:
> git submodule foreach 'git pull --ff-only origin master'
> @@ -199,7 +199,7 @@ stats:
> @for i in $(LINGUAS); do echo -n "$$i: "; msgfmt --statistics -o /dev/null $$i.po; done
>
> init-%.po: messages.pot
> - msginit -i $^ -l $^ -o $*.po --no-translator
> + msginit --input $^ --locale $^ --output-file $*.po --no-translator
>
> .INTERMEDIATE: messages.pot
> messages.pot: proxmox-widget-toolkit.pot proxmox-mailgateway.pot pve-manager.pot proxmox-backup.pot proxmox-datacenter-manager-ui.pot pve-yew-mobile-gui.pot pmg-yew-quarantine-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot
next prev parent reply other threads:[~2026-07-24 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 11:12 [PATCH proxmox-i18n v2 00/11] Makefile simplifications and improvements Maximiliano Sandoval
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 01/11] make: catalog-%.mo: explicitly set template file Maximiliano Sandoval
2026-07-24 13:06 ` Shannon Sterz
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 02/11] make: simplify msgmerge commands Maximiliano Sandoval
2026-07-24 13:06 ` Shannon Sterz
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 03/11] make: clean: remove *.mo files Maximiliano Sandoval
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 04/11] make: use long options for msgmerge and msginit Maximiliano Sandoval
2026-07-24 13:06 ` Shannon Sterz [this message]
2026-07-24 13:12 ` Shannon Sterz
2026-07-24 13:25 ` Maximiliano Sandoval
2026-07-24 13:31 ` Shannon Sterz
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 05/11] make: do_update: add --update for msgmerge Maximiliano Sandoval
2026-07-24 13:06 ` Shannon Sterz
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 06/11] make: do_update: add --previous flag to msgmerge Maximiliano Sandoval
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 07/11] gitignore: remove proxmox-datacenter-manager.pot Maximiliano Sandoval
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 08/11] make: move linguas to a file Maximiliano Sandoval
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 09/11] make: add linguas checks Maximiliano Sandoval
2026-07-24 13:06 ` Shannon Sterz
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 10/11] make: init-%.po: add language to linguas Maximiliano Sandoval
2026-07-24 11:12 ` [PATCH proxmox-i18n v2 11/11] make: add targets to update specific PO files Maximiliano Sandoval
2026-07-24 13:08 ` [PATCH proxmox-i18n v2 00/11] Makefile simplifications and improvements Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK6TO6766HRY.1NQ4RWYQMFIE7@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox