From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 69E2D1FF0E6 for ; Fri, 24 Jul 2026 15:07:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3C644214CF; Fri, 24 Jul 2026 15:07:11 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Jul 2026 15:06:35 +0200 Message-Id: To: "Maximiliano Sandoval" , Subject: Re: [PATCH proxmox-i18n v2 09/11] make: add linguas checks X-Mailer: aerc 0.20.0 References: <20260724111257.325867-1-m.sandoval@proxmox.com> <20260724111257.325867-10-m.sandoval@proxmox.com> In-Reply-To: <20260724111257.325867-10-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784898364276 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.206 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JJEKGLQB6NEO56AA2VMTQ5BHODQWDUMO X-Message-ID-Hash: JJEKGLQB6NEO56AA2VMTQ5BHODQWDUMO X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote: > Cross-references the list of languages in LINGUAS and the *.po files. > > Signed-off-by: Maximiliano Sandoval > --- > > Notes: > This should be equivalent to the less-verbose: > > test "$(ls *.po | sed 's/.po//')" =3D "$(cat LINGUAS)" > > but easier to understand why it fails on failure. > > Makefile | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index ceac4eab..3dd30401 100644 > --- a/Makefile > +++ b/Makefile > @@ -202,5 +202,19 @@ upload: upload-pve upload-pmg upload-pbs upload-pdm > check-%: %.po > msgfmt --check $*.po > > +.PHONY: check-linguas > +check-linguas: > + sort --check --uniq LINGUAS > + set -e; for lang in $(LINGUAS); do \ > + echo "checking if $$lang.po exists"; \ > + test -f $$lang.po; \ > + done isn't this check covered by the specific `check-${langcode}` checks? make will just fail if a prerequisite isn't present and there is no target to produce it. so here removing a .po file will make the accompanying check-${langcode} fail as there is no target to make it. > + set -e; for lang in $(shell ls *.po | sed 's/\.po//'); do \ > + echo "checking if $$lang is in LINGUAS"; \ > + grep --quiet --line-regexp $$lang LINGUAS; \ > + done > + > .PHONY: check > -check: $(addprefix check-, $(LINGUAS)) > +check: > + $(MAKE) $(addprefix check-, $(LINGUAS)) > + $(MAKE) check-linguas any reason you do a second invocation of make here instead of sticking to make's prerequisite mechanism? iirc the latter has the upside of being more nicely parallelizable with `-j`