From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 474721FF0E6 for ; Fri, 24 Jul 2026 15:06:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9E9E6214A7; Fri, 24 Jul 2026 15:06:21 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Jul 2026 15:06:17 +0200 Message-Id: Subject: Re: [PATCH proxmox-i18n v2 01/11] make: catalog-%.mo: explicitly set template file To: "Maximiliano Sandoval" , X-Mailer: aerc 0.20.0 References: <20260724111257.325867-1-m.sandoval@proxmox.com> <20260724111257.325867-2-m.sandoval@proxmox.com> In-Reply-To: <20260724111257.325867-2-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784898346641 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.269 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YM3KAHOVRHSJFS6UOQUA3P274PDVDMM7 X-Message-ID-Hash: YM3KAHOVRHSJFS6UOQUA3P274PDVDMM7 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote: > msgmerge takes exactly two arguments. Fixes a regression from aacd4e7a. tiny nit: quoting the commit message here might be nice, but that's not really much of a problem. the commit message was this btw: > buildsys: use combined message catalogue for now > > Signed-off-by: Maximiliano Sandoval > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 86f81e9b..b233828b 100644 > --- a/Makefile > +++ b/Makefile > @@ -125,8 +125,8 @@ pve-lang-%.js: %.po > pbs-lang-%.js: %.po > ./po2js.pl -t pbs -v "$(DEB_VERSION)" -o pbs-lang-$*.js $? > > -catalog-%.mo: %.po > - msgmerge $^ | msgattrib --no-fuzzy --no-obsolete | msgfmt --verbose --o= utput-file $@ $<; > +catalog-%.mo: %.po messages.pot > + msgmerge $*.po messages.pot | msgattrib --no-fuzzy --no-obsolete | msgf= mt --verbose --output-file $@ $<; imo `msmerge $< message.po |...` would convey your intend here a little bit more clearly. `$<` being the first full prerequisite. `$*` as the target file stems is imo a bit harder to understand personally. but as this is more of a personal taste issue, it shouldn't be blocker imo. since you use that throughout, it won't mention it everytime. > > .INTERMEDIATE: pve-yew-mobile-all.pot > pve-yew-mobile-all.pot: pve-yew-mobile-gui.pot proxmox-yew-comp.pot prox= mox-yew-widget-toolkit.pot