From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 999511FF0E6 for ; Fri, 24 Jul 2026 15:08:44 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 60664214DA; Fri, 24 Jul 2026 15:08:44 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Jul 2026 15:08:11 +0200 Message-Id: To: "Maximiliano Sandoval" , Subject: Re: [PATCH proxmox-i18n v2 00/11] Makefile simplifications and improvements X-Mailer: aerc 0.20.0 References: <20260724111257.325867-1-m.sandoval@proxmox.com> In-Reply-To: <20260724111257.325867-1-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784898461149 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.194 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W3HQWPLMVBMIIOABCEGNARDLHZBJESNV X-Message-ID-Hash: W3HQWPLMVBMIIOABCEGNARDLHZBJESNV X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 24, 2026 at 1:12 PM CEST, Maximiliano Sandoval wrote: > The main difference in behavior is that we add --previous to the msgmerge > command used to update the PO files. This can add some extra information = to > translations, which can make it easier to determine whether the previous > translation is still valid or what kind of modifications it needs. > > See individual commits and their notes. > > Additionally: > - there are a couple of cleanups > - we move the LINGUAS to a dedicated file > - check LINGUAS and add languages to it on the init-%.po target > - split the do_update target on a per-language basis > > Differences from v1: > - Move LINGUAS to a dedicated file > - split the do_update target on a per-language basis > > Maximiliano Sandoval (11): > make: catalog-%.mo: explicitly set template file > make: simplify msgmerge commands > make: clean: remove *.mo files > make: use long options for msgmerge and msginit > make: do_update: add --update for msgmerge > make: do_update: add --previous flag to msgmerge > gitignore: remove proxmox-datacenter-manager.pot > make: move linguas to a file > make: add linguas checks > make: init-%.po: add language to linguas > make: add targets to update specific PO files > > .gitignore | 1 - > LINGUAS | 32 ++++++++++++++++++++++++ > Makefile | 72 ++++++++++++++++++++---------------------------------- > 3 files changed, 59 insertions(+), 46 deletions(-) > create mode 100644 LINGUAS gave the targets here a quick spin and it looked alright to me. i left a few small comments on style and make file structure, but nothing to major so consider this: Reviewed-by: Shannon Sterz