* [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
@ 2026-05-26 14:30 Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:30 UTC (permalink / raw)
To: pdm-devel
* properly quote actions
* rephrase some tips slightly for clarity.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
ui/src/configuration/subscription_keys.rs | 6 +++---
ui/src/configuration/subscription_registry.rs | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
index 5f3e9aa..c35a546 100644
--- a/ui/src/configuration/subscription_keys.rs
+++ b/ui/src/configuration/subscription_keys.rs
@@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
.on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
)
.tip(tr!(
- "Add one or more subscription keys to the pool; the Assign step \
+ "Add one or more subscription keys to the pool; the 'Assign' step \
happens later."
)),
)
@@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
.on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
)
.tip(tr!(
- "Pin the selected key to a remote node; Apply Pending pushes the \
+ "Pin the selected key to a remote node; 'Apply Pending' pushes the \
assignment to the remote."
)),
)
@@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
)
.tip(tr!(
"Propose a one-key-per-node assignment for nodes that have no active \
- subscription, then queue it pending Apply."
+ subscription, then queue applying it."
)),
);
}
diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
index 45d8ccc..60cc43e 100644
--- a/ui/src/configuration/subscription_registry.rs
+++ b/ui/src/configuration/subscription_registry.rs
@@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
.with_child(tr!("{n} pending push(es)", n = push_count)),
)
.tip(tr!(
- "{n} pool key(s) queued for push; Apply Pending will install them on the remote.",
+ "{n} pool key(s) queued for push; 'Apply Pending' will install them on the remote.",
n = push_count,
)),
);
@@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
.with_child(tr!("{n} pending clear(s)", n = clear_count)),
)
.tip(tr!(
- "{n} live subscription(s) queued for removal; Apply Pending will free them.",
+ "{n} live subscription(s) queued for removal; 'Apply Pending' will free them.",
n = clear_count,
)),
);
@@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html {
.with_child(text),
)
.tip(tr!(
- "Not in pool - Adopt Key imports this live subscription."
+ "Not in pool - 'Adopt Key' imports this live subscription."
))
.into()
} else {
@@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp {
.on_activate(ctx.link().callback(|_| Msg::QueueClearForSelectedNode)),
)
.tip(tr!(
- "Queue the selected node's live subscription for removal at the next Apply Pending, \
+ "Queue the selected node's live subscription for removal at the next 'Apply Pending', \
freeing the key for reassignment. Available for a pool-managed node; for a foreign \
subscription, adopt it first."
));
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:30 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
@ 2026-05-26 14:39 ` Lukas Wagner
2026-05-26 14:46 ` Shannon Sterz
2026-05-26 14:51 ` Thomas Lamprecht
2026-05-26 14:51 ` Superseded: " Shannon Sterz
2 siblings, 1 reply; 9+ messages in thread
From: Lukas Wagner @ 2026-05-26 14:39 UTC (permalink / raw)
To: Shannon Sterz, pdm-devel
On Tue May 26, 2026 at 4:30 PM CEST, Shannon Sterz wrote:
> * properly quote actions
> * rephrase some tips slightly for clarity.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> ui/src/configuration/subscription_keys.rs | 6 +++---
> ui/src/configuration/subscription_registry.rs | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
> index 5f3e9aa..c35a546 100644
> --- a/ui/src/configuration/subscription_keys.rs
> +++ b/ui/src/configuration/subscription_keys.rs
> @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
> )
> .tip(tr!(
> - "Add one or more subscription keys to the pool; the Assign step \
> + "Add one or more subscription keys to the pool; the 'Assign' step \
> happens later."
> )),
> )
> @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
> )
> .tip(tr!(
> - "Pin the selected key to a remote node; Apply Pending pushes the \
> + "Pin the selected key to a remote node; 'Apply Pending' pushes the \
> assignment to the remote."
> )),
> )
> @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> )
> .tip(tr!(
> "Propose a one-key-per-node assignment for nodes that have no active \
> - subscription, then queue it pending Apply."
> + subscription, then queue applying it."
> )),
Maybe
"Propose a key assignment for nodes that have no active subscription,
allowing to queue it for applying the proposal later."
could be a tad more clear? Although it might be a bit long for a
tooltip...
The remaining changes look good to me, I think quoting the 'action'
looks nicer in the tooltip.
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:39 ` Lukas Wagner
@ 2026-05-26 14:46 ` Shannon Sterz
2026-05-26 14:47 ` Lukas Wagner
0 siblings, 1 reply; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:46 UTC (permalink / raw)
To: Lukas Wagner, pdm-devel
On Tue May 26, 2026 at 4:39 PM CEST, Lukas Wagner wrote:
> On Tue May 26, 2026 at 4:30 PM CEST, Shannon Sterz wrote:
>> * properly quote actions
>> * rephrase some tips slightly for clarity.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>> ui/src/configuration/subscription_keys.rs | 6 +++---
>> ui/src/configuration/subscription_registry.rs | 8 ++++----
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
>> index 5f3e9aa..c35a546 100644
>> --- a/ui/src/configuration/subscription_keys.rs
>> +++ b/ui/src/configuration/subscription_keys.rs
>> @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
>> .on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
>> )
>> .tip(tr!(
>> - "Add one or more subscription keys to the pool; the Assign step \
>> + "Add one or more subscription keys to the pool; the 'Assign' step \
>> happens later."
>> )),
>> )
>> @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
>> .on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
>> )
>> .tip(tr!(
>> - "Pin the selected key to a remote node; Apply Pending pushes the \
>> + "Pin the selected key to a remote node; 'Apply Pending' pushes the \
>> assignment to the remote."
>> )),
>> )
>> @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
>> )
>> .tip(tr!(
>> "Propose a one-key-per-node assignment for nodes that have no active \
>> - subscription, then queue it pending Apply."
>> + subscription, then queue applying it."
>> )),
>
> Maybe
>
> "Propose a key assignment for nodes that have no active subscription,
> allowing to queue it for applying the proposal later."
>
> could be a tad more clear? Although it might be a bit long for a
> tooltip...
>
> The remaining changes look good to me, I think quoting the 'action'
> looks nicer in the tooltip.
>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Maybe:
"Propose a key assignment for nodes that have no active subscription and queue its application."
?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:46 ` Shannon Sterz
@ 2026-05-26 14:47 ` Lukas Wagner
2026-05-26 14:48 ` Shannon Sterz
0 siblings, 1 reply; 9+ messages in thread
From: Lukas Wagner @ 2026-05-26 14:47 UTC (permalink / raw)
To: Shannon Sterz, Lukas Wagner, pdm-devel
On Tue May 26, 2026 at 4:46 PM CEST, Shannon Sterz wrote:
>>> .tip(tr!(
>>> "Propose a one-key-per-node assignment for nodes that have no active \
>>> - subscription, then queue it pending Apply."
>>> + subscription, then queue applying it."
>>> )),
>>
>> Maybe
>>
>> "Propose a key assignment for nodes that have no active subscription,
>> allowing to queue it for applying the proposal later."
>>
>> could be a tad more clear? Although it might be a bit long for a
>> tooltip...
>>
>> The remaining changes look good to me, I think quoting the 'action'
>> looks nicer in the tooltip.
>>
>> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
>
> Maybe:
>
> "Propose a key assignment for nodes that have no active subscription and queue its application."
>
> ?
Sounds good to me :)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:47 ` Lukas Wagner
@ 2026-05-26 14:48 ` Shannon Sterz
0 siblings, 0 replies; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:48 UTC (permalink / raw)
To: Lukas Wagner, pdm-devel
On Tue May 26, 2026 at 4:47 PM CEST, Lukas Wagner wrote:
> On Tue May 26, 2026 at 4:46 PM CEST, Shannon Sterz wrote:
>>>> .tip(tr!(
>>>> "Propose a one-key-per-node assignment for nodes that have no active \
>>>> - subscription, then queue it pending Apply."
>>>> + subscription, then queue applying it."
>>>> )),
>>>
>>> Maybe
>>>
>>> "Propose a key assignment for nodes that have no active subscription,
>>> allowing to queue it for applying the proposal later."
>>>
>>> could be a tad more clear? Although it might be a bit long for a
>>> tooltip...
>>>
>>> The remaining changes look good to me, I think quoting the 'action'
>>> looks nicer in the tooltip.
>>>
>>> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
>>
>> Maybe:
>>
>> "Propose a key assignment for nodes that have no active subscription and queue its application."
>>
>> ?
>
> Sounds good to me :)
will send a v2 to in a minute then :)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:30 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
@ 2026-05-26 14:51 ` Thomas Lamprecht
2026-05-26 14:53 ` Shannon Sterz
2026-05-26 14:51 ` Superseded: " Shannon Sterz
2 siblings, 1 reply; 9+ messages in thread
From: Thomas Lamprecht @ 2026-05-26 14:51 UTC (permalink / raw)
To: Shannon Sterz, pdm-devel
Am 26.05.26 um 16:30 schrieb Shannon Sterz:
> * properly quote actions
Some rationale would be nice, I've seen both in practice and the casing
should help. But no hard feelings here, it might be a bit more explicit.
> * rephrase some tips slightly for clarity.
Only one is really changed FWICT?
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> ui/src/configuration/subscription_keys.rs | 6 +++---
> ui/src/configuration/subscription_registry.rs | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
> index 5f3e9aa..c35a546 100644
> --- a/ui/src/configuration/subscription_keys.rs
> +++ b/ui/src/configuration/subscription_keys.rs
)
> @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> )
> .tip(tr!(
> "Propose a one-key-per-node assignment for nodes that have no active \
> - subscription, then queue it pending Apply."
> + subscription, then queue applying it."
This seems not really making it better IMO, what about:
"... then queue it for the next 'Apply Pending'."
As then the user gets explicitly told what unblocks the queued action.
> )),
> );
> }
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:51 ` Thomas Lamprecht
@ 2026-05-26 14:53 ` Shannon Sterz
0 siblings, 0 replies; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:53 UTC (permalink / raw)
To: Thomas Lamprecht, pdm-devel
On Tue May 26, 2026 at 4:51 PM CEST, Thomas Lamprecht wrote:
> Am 26.05.26 um 16:30 schrieb Shannon Sterz:
>> * properly quote actions
> Some rationale would be nice, I've seen both in practice and the casing
> should help. But no hard feelings here, it might be a bit more explicit.
>
>> * rephrase some tips slightly for clarity.
> Only one is really changed FWICT?
>
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>> ui/src/configuration/subscription_keys.rs | 6 +++---
>> ui/src/configuration/subscription_registry.rs | 8 ++++----
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
>> index 5f3e9aa..c35a546 100644
>> --- a/ui/src/configuration/subscription_keys.rs
>> +++ b/ui/src/configuration/subscription_keys.rs
> )
>> @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
>> )
>> .tip(tr!(
>> "Propose a one-key-per-node assignment for nodes that have no active \
>> - subscription, then queue it pending Apply."
>> + subscription, then queue applying it."
> This seems not really making it better IMO, what about:
>
> "... then queue it for the next 'Apply Pending'."
>
> As then the user gets explicitly told what unblocks the queued action.
Hmm sure, sorry i missed that before sending a v2, will send a v3.
>
>> )),
>> );
>> }
^ permalink raw reply [flat|nested] 9+ messages in thread
* Superseded: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:30 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
2026-05-26 14:51 ` Thomas Lamprecht
@ 2026-05-26 14:51 ` Shannon Sterz
2 siblings, 0 replies; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:51 UTC (permalink / raw)
To: Shannon Sterz, pdm-devel
Superseded-by: https://lore.proxmox.com/pdm-devel/20260526145041.509128-1-s.sterz@proxmox.com/T/#u
On Tue May 26, 2026 at 4:30 PM CEST, Shannon Sterz wrote:
> * properly quote actions
> * rephrase some tips slightly for clarity.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> ui/src/configuration/subscription_keys.rs | 6 +++---
> ui/src/configuration/subscription_registry.rs | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
> index 5f3e9aa..c35a546 100644
> --- a/ui/src/configuration/subscription_keys.rs
> +++ b/ui/src/configuration/subscription_keys.rs
> @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
> )
> .tip(tr!(
> - "Add one or more subscription keys to the pool; the Assign step \
> + "Add one or more subscription keys to the pool; the 'Assign' step \
> happens later."
> )),
> )
> @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
> )
> .tip(tr!(
> - "Pin the selected key to a remote node; Apply Pending pushes the \
> + "Pin the selected key to a remote node; 'Apply Pending' pushes the \
> assignment to the remote."
> )),
> )
> @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> )
> .tip(tr!(
> "Propose a one-key-per-node assignment for nodes that have no active \
> - subscription, then queue it pending Apply."
> + subscription, then queue applying it."
> )),
> );
> }
> diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
> index 45d8ccc..60cc43e 100644
> --- a/ui/src/configuration/subscription_registry.rs
> +++ b/ui/src/configuration/subscription_registry.rs
> @@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
> .with_child(tr!("{n} pending push(es)", n = push_count)),
> )
> .tip(tr!(
> - "{n} pool key(s) queued for push; Apply Pending will install them on the remote.",
> + "{n} pool key(s) queued for push; 'Apply Pending' will install them on the remote.",
> n = push_count,
> )),
> );
> @@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
> .with_child(tr!("{n} pending clear(s)", n = clear_count)),
> )
> .tip(tr!(
> - "{n} live subscription(s) queued for removal; Apply Pending will free them.",
> + "{n} live subscription(s) queued for removal; 'Apply Pending' will free them.",
> n = clear_count,
> )),
> );
> @@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html {
> .with_child(text),
> )
> .tip(tr!(
> - "Not in pool - Adopt Key imports this live subscription."
> + "Not in pool - 'Adopt Key' imports this live subscription."
> ))
> .into()
> } else {
> @@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp {
> .on_activate(ctx.link().callback(|_| Msg::QueueClearForSelectedNode)),
> )
> .tip(tr!(
> - "Queue the selected node's live subscription for removal at the next Apply Pending, \
> + "Queue the selected node's live subscription for removal at the next 'Apply Pending', \
> freeing the key for reassignment. Available for a pool-managed node; for a foreign \
> subscription, adopt it first."
> ));
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
@ 2026-05-26 14:50 Shannon Sterz
2026-05-26 14:58 ` Superseded: " Shannon Sterz
0 siblings, 1 reply; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:50 UTC (permalink / raw)
To: pdm-devel
* properly quote actions
* rephrase some tips slightly for clarity.
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
---
ui/src/configuration/subscription_keys.rs | 8 ++++----
ui/src/configuration/subscription_registry.rs | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
index 5f3e9aa..79776ab 100644
--- a/ui/src/configuration/subscription_keys.rs
+++ b/ui/src/configuration/subscription_keys.rs
@@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
.on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
)
.tip(tr!(
- "Add one or more subscription keys to the pool; the Assign step \
+ "Add one or more subscription keys to the pool; the 'Assign' step \
happens later."
)),
)
@@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
.on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
)
.tip(tr!(
- "Pin the selected key to a remote node; Apply Pending pushes the \
+ "Pin the selected key to a remote node; 'Apply Pending' pushes the \
assignment to the remote."
)),
)
@@ -324,8 +324,8 @@ impl LoadableComponent for SubscriptionKeyGridComp {
.on_activate(move |_| cb.emit(())),
)
.tip(tr!(
- "Propose a one-key-per-node assignment for nodes that have no active \
- subscription, then queue it pending Apply."
+ "Propose a key assignment for nodes that have no active subscription \
+ and queue its application."
)),
);
}
diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
index 45d8ccc..60cc43e 100644
--- a/ui/src/configuration/subscription_registry.rs
+++ b/ui/src/configuration/subscription_registry.rs
@@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
.with_child(tr!("{n} pending push(es)", n = push_count)),
)
.tip(tr!(
- "{n} pool key(s) queued for push; Apply Pending will install them on the remote.",
+ "{n} pool key(s) queued for push; 'Apply Pending' will install them on the remote.",
n = push_count,
)),
);
@@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
.with_child(tr!("{n} pending clear(s)", n = clear_count)),
)
.tip(tr!(
- "{n} live subscription(s) queued for removal; Apply Pending will free them.",
+ "{n} live subscription(s) queued for removal; 'Apply Pending' will free them.",
n = clear_count,
)),
);
@@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html {
.with_child(text),
)
.tip(tr!(
- "Not in pool - Adopt Key imports this live subscription."
+ "Not in pool - 'Adopt Key' imports this live subscription."
))
.into()
} else {
@@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp {
.on_activate(ctx.link().callback(|_| Msg::QueueClearForSelectedNode)),
)
.tip(tr!(
- "Queue the selected node's live subscription for removal at the next Apply Pending, \
+ "Queue the selected node's live subscription for removal at the next 'Apply Pending', \
freeing the key for reassignment. Available for a pool-managed node; for a foreign \
subscription, adopt it first."
));
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Superseded: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
2026-05-26 14:50 Shannon Sterz
@ 2026-05-26 14:58 ` Shannon Sterz
0 siblings, 0 replies; 9+ messages in thread
From: Shannon Sterz @ 2026-05-26 14:58 UTC (permalink / raw)
To: Shannon Sterz, pdm-devel
Superseded: https://lore.proxmox.com/pdm-devel/20260526145806.521576-1-s.sterz@proxmox.com/T/#u
On Tue May 26, 2026 at 4:50 PM CEST, Shannon Sterz wrote:
> * properly quote actions
> * rephrase some tips slightly for clarity.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> ui/src/configuration/subscription_keys.rs | 8 ++++----
> ui/src/configuration/subscription_registry.rs | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
> index 5f3e9aa..79776ab 100644
> --- a/ui/src/configuration/subscription_keys.rs
> +++ b/ui/src/configuration/subscription_keys.rs
> @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
> )
> .tip(tr!(
> - "Add one or more subscription keys to the pool; the Assign step \
> + "Add one or more subscription keys to the pool; the 'Assign' step \
> happens later."
> )),
> )
> @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
> )
> .tip(tr!(
> - "Pin the selected key to a remote node; Apply Pending pushes the \
> + "Pin the selected key to a remote node; 'Apply Pending' pushes the \
> assignment to the remote."
> )),
> )
> @@ -324,8 +324,8 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(move |_| cb.emit(())),
> )
> .tip(tr!(
> - "Propose a one-key-per-node assignment for nodes that have no active \
> - subscription, then queue it pending Apply."
> + "Propose a key assignment for nodes that have no active subscription \
> + and queue its application."
> )),
> );
> }
> diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
> index 45d8ccc..60cc43e 100644
> --- a/ui/src/configuration/subscription_registry.rs
> +++ b/ui/src/configuration/subscription_registry.rs
> @@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
> .with_child(tr!("{n} pending push(es)", n = push_count)),
> )
> .tip(tr!(
> - "{n} pool key(s) queued for push; Apply Pending will install them on the remote.",
> + "{n} pool key(s) queued for push; 'Apply Pending' will install them on the remote.",
> n = push_count,
> )),
> );
> @@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
> .with_child(tr!("{n} pending clear(s)", n = clear_count)),
> )
> .tip(tr!(
> - "{n} live subscription(s) queued for removal; Apply Pending will free them.",
> + "{n} live subscription(s) queued for removal; 'Apply Pending' will free them.",
> n = clear_count,
> )),
> );
> @@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html {
> .with_child(text),
> )
> .tip(tr!(
> - "Not in pool - Adopt Key imports this live subscription."
> + "Not in pool - 'Adopt Key' imports this live subscription."
> ))
> .into()
> } else {
> @@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp {
> .on_activate(ctx.link().callback(|_| Msg::QueueClearForSelectedNode)),
> )
> .tip(tr!(
> - "Queue the selected node's live subscription for removal at the next Apply Pending, \
> + "Queue the selected node's live subscription for removal at the next 'Apply Pending', \
> freeing the key for reassignment. Available for a pool-managed node; for a foreign \
> subscription, adopt it first."
> ));
> --
> 2.47.3
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-05-26 14:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 14:30 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
2026-05-26 14:46 ` Shannon Sterz
2026-05-26 14:47 ` Lukas Wagner
2026-05-26 14:48 ` Shannon Sterz
2026-05-26 14:51 ` Thomas Lamprecht
2026-05-26 14:53 ` Shannon Sterz
2026-05-26 14:51 ` Superseded: " Shannon Sterz
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 14:50 Shannon Sterz
2026-05-26 14:58 ` Superseded: " Shannon Sterz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox