From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>,
<pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
Date: Tue, 26 May 2026 16:47:43 +0200 [thread overview]
Message-ID: <DISOVLH2AQ6Q.2AL4LTZDOGB3R@proxmox.com> (raw)
In-Reply-To: <DISOUCWSKXK4.XQTY9KVMAQ9H@proxmox.com>
On Tue May 26, 2026 at 4:46 PM CEST, Shannon Sterz wrote:
>>> .tip(tr!(
>>> "Propose a one-key-per-node assignment for nodes that have no active \
>>> - subscription, then queue it pending Apply."
>>> + subscription, then queue applying it."
>>> )),
>>
>> Maybe
>>
>> "Propose a key assignment for nodes that have no active subscription,
>> allowing to queue it for applying the proposal later."
>>
>> could be a tad more clear? Although it might be a bit long for a
>> tooltip...
>>
>> The remaining changes look good to me, I think quoting the 'action'
>> looks nicer in the tooltip.
>>
>> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
>
> Maybe:
>
> "Propose a key assignment for nodes that have no active subscription and queue its application."
>
> ?
Sounds good to me :)
next prev parent reply other threads:[~2026-05-26 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:30 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
2026-05-26 14:46 ` Shannon Sterz
2026-05-26 14:47 ` Lukas Wagner [this message]
2026-05-26 14:48 ` Shannon Sterz
2026-05-26 14:51 ` Thomas Lamprecht
2026-05-26 14:53 ` Shannon Sterz
2026-05-26 14:51 ` Superseded: " Shannon Sterz
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 14:50 Shannon Sterz
2026-05-26 14:51 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DISOVLH2AQ6Q.2AL4LTZDOGB3R@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox