From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
Date: Tue, 26 May 2026 16:51:06 +0200 [thread overview]
Message-ID: <a9b5563f-e532-423b-be2b-82eea5534fc8@proxmox.com> (raw)
In-Reply-To: <20260526143027.482438-1-s.sterz@proxmox.com>
Am 26.05.26 um 16:30 schrieb Shannon Sterz:
> * properly quote actions
Some rationale would be nice, I've seen both in practice and the casing
should help. But no hard feelings here, it might be a bit more explicit.
> * rephrase some tips slightly for clarity.
Only one is really changed FWICT?
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> ui/src/configuration/subscription_keys.rs | 6 +++---
> ui/src/configuration/subscription_registry.rs | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
> index 5f3e9aa..c35a546 100644
> --- a/ui/src/configuration/subscription_keys.rs
> +++ b/ui/src/configuration/subscription_keys.rs
)
> @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> )
> .tip(tr!(
> "Propose a one-key-per-node assignment for nodes that have no active \
> - subscription, then queue it pending Apply."
> + subscription, then queue applying it."
This seems not really making it better IMO, what about:
"... then queue it for the next 'Apply Pending'."
As then the user gets explicitly told what unblocks the queued action.
> )),
> );
> }
next prev parent reply other threads:[~2026-05-26 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:30 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
2026-05-26 14:46 ` Shannon Sterz
2026-05-26 14:47 ` Lukas Wagner
2026-05-26 14:48 ` Shannon Sterz
2026-05-26 14:51 ` Thomas Lamprecht [this message]
2026-05-26 14:53 ` Shannon Sterz
2026-05-26 14:51 ` Superseded: " Shannon Sterz
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 14:50 Shannon Sterz
2026-05-26 14:51 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9b5563f-e532-423b-be2b-82eea5534fc8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox