From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry
Date: Tue, 26 May 2026 16:51:28 +0200 [thread overview]
Message-ID: <DISOYGZT4S6I.2F1ZZAEHGP8Y@proxmox.com> (raw)
In-Reply-To: <20260526145041.509128-1-s.sterz@proxmox.com>
ah sorry this is missing a v2
On Tue May 26, 2026 at 4:50 PM CEST, Shannon Sterz wrote:
> * properly quote actions
> * rephrase some tips slightly for clarity.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> ui/src/configuration/subscription_keys.rs | 8 ++++----
> ui/src/configuration/subscription_registry.rs | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configuration/subscription_keys.rs
> index 5f3e9aa..79776ab 100644
> --- a/ui/src/configuration/subscription_keys.rs
> +++ b/ui/src/configuration/subscription_keys.rs
> @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Add))),
> )
> .tip(tr!(
> - "Add one or more subscription keys to the pool; the Assign step \
> + "Add one or more subscription keys to the pool; the 'Assign' step \
> happens later."
> )),
> )
> @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(link.change_view_callback(|_| Some(ViewState::Assign))),
> )
> .tip(tr!(
> - "Pin the selected key to a remote node; Apply Pending pushes the \
> + "Pin the selected key to a remote node; 'Apply Pending' pushes the \
> assignment to the remote."
> )),
> )
> @@ -324,8 +324,8 @@ impl LoadableComponent for SubscriptionKeyGridComp {
> .on_activate(move |_| cb.emit(())),
> )
> .tip(tr!(
> - "Propose a one-key-per-node assignment for nodes that have no active \
> - subscription, then queue it pending Apply."
> + "Propose a key assignment for nodes that have no active subscription \
> + and queue its application."
> )),
> );
> }
> diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
> index 45d8ccc..60cc43e 100644
> --- a/ui/src/configuration/subscription_registry.rs
> +++ b/ui/src/configuration/subscription_registry.rs
> @@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
> .with_child(tr!("{n} pending push(es)", n = push_count)),
> )
> .tip(tr!(
> - "{n} pool key(s) queued for push; Apply Pending will install them on the remote.",
> + "{n} pool key(s) queued for push; 'Apply Pending' will install them on the remote.",
> n = push_count,
> )),
> );
> @@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -> Row {
> .with_child(tr!("{n} pending clear(s)", n = clear_count)),
> )
> .tip(tr!(
> - "{n} live subscription(s) queued for removal; Apply Pending will free them.",
> + "{n} live subscription(s) queued for removal; 'Apply Pending' will free them.",
> n = clear_count,
> )),
> );
> @@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html {
> .with_child(text),
> )
> .tip(tr!(
> - "Not in pool - Adopt Key imports this live subscription."
> + "Not in pool - 'Adopt Key' imports this live subscription."
> ))
> .into()
> } else {
> @@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp {
> .on_activate(ctx.link().callback(|_| Msg::QueueClearForSelectedNode)),
> )
> .tip(tr!(
> - "Queue the selected node's live subscription for removal at the next Apply Pending, \
> + "Queue the selected node's live subscription for removal at the next 'Apply Pending', \
> freeing the key for reassignment. Available for a pool-managed node; for a foreign \
> subscription, adopt it first."
> ));
> --
> 2.47.3
next prev parent reply other threads:[~2026-05-26 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:50 [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry Shannon Sterz
2026-05-26 14:51 ` Shannon Sterz [this message]
2026-05-26 14:58 ` Superseded: " Shannon Sterz
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 14:30 Shannon Sterz
2026-05-26 14:39 ` Lukas Wagner
2026-05-26 14:46 ` Shannon Sterz
2026-05-26 14:47 ` Lukas Wagner
2026-05-26 14:48 ` Shannon Sterz
2026-05-26 14:51 ` Thomas Lamprecht
2026-05-26 14:53 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DISOYGZT4S6I.2F1ZZAEHGP8Y@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox