From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH v8 manager 41/43] ui: storage: point the iSCSI and LVM add dialogs to the SAN view
Date: Thu, 19 Nov 2026 20:46:46 +0100 [thread overview]
Message-ID: <20261119194655.3163258-42-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261119194655.3163258-1-t.lamprecht@proxmox.com>
Admins new to Proxmox VE look for adding their SAN under Datacenter >
Storage > Add. There, the iSCSI dialog connects a target without a
volume group on top and, by default, without multipath. So they end up
with neither a storage that can allocate guest disks nor path
redundancy. The guided setups that do both are in the SAN view, which
nothing in these dialogs mentions.
Add a note that names the SAN view to the add dialogs of iSCSI and LVM,
which stay as they are for attaching existing targets and volume groups.
The dialog that creates a volume group under Node > Disks gets a note
too, which says that on a SAN LUN its Add Storage option adds a shared
storage for all nodes. It adds no multipath entry, so for a Fibre
Channel LUN without a map, the volume group lands on a single path.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
www/manager6/SANUtils.js | 38 +++++++++++++++++++++++++++++++
www/manager6/node/LVM.js | 5 ++++
www/manager6/storage/Base.js | 5 ++++
www/manager6/storage/IScsiEdit.js | 3 +++
www/manager6/storage/LVMEdit.js | 3 +++
5 files changed, 54 insertions(+)
diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js
index 5cd8abd76..84d482f36 100644
--- a/www/manager6/SANUtils.js
+++ b/www/manager6/SANUtils.js
@@ -153,6 +153,44 @@ Ext.define('PVE.SANUtils', {
);
},
+ // Selects Datacenter > Storage > SAN, as the TFA entry of the user menu does for its panel.
+ showSANView: function () {
+ Ext.state.Manager.getProvider().set('dctab', { value: 'san' }, true);
+ Ext.ComponentQuery.query('pveStdWorkspace')[0]?.selectById('root');
+ },
+
+ // A note for the add dialogs of storages on a SAN, which points to the guided setups of the
+ // SAN view. Its link closes the dialog and opens the view.
+ sanViewNote: function (text) {
+ let path = `${gettext('Datacenter')} > ${gettext('Storage')} > SAN`;
+ let link = `<a href="#" style="white-space: nowrap;">${Ext.htmlEncode(path)}</a>`;
+ return {
+ xtype: 'component',
+ margin: '5 0 0 0',
+ html:
+ `<span class="pmx-hint">${Ext.htmlEncode(gettext('Note:'))}</span> ` +
+ Ext.String.format(Ext.htmlEncode(text), link),
+ listeners: {
+ afterrender: function (cmp) {
+ let follow = function (event) {
+ event.stopEvent();
+ cmp.up('window')?.close();
+ PVE.SANUtils.showSANView();
+ };
+ cmp.mon(cmp.getEl(), 'click', follow, null, { delegate: 'a' });
+ // an edit window handles Enter for its default button, so no click follows it
+ cmp.mon(
+ cmp.getEl(),
+ 'keydown',
+ (event) => event.getKey() === event.ENTER && follow(event),
+ null,
+ { delegate: 'a' },
+ );
+ },
+ },
+ };
+ },
+
renderSanTransport: function (value) {
return Ext.htmlEncode(
{
diff --git a/www/manager6/node/LVM.js b/www/manager6/node/LVM.js
index 11b03612d..ffd432fd5 100644
--- a/www/manager6/node/LVM.js
+++ b/www/manager6/node/LVM.js
@@ -42,6 +42,11 @@ Ext.define('PVE.node.CreateLVM', {
fieldLabel: gettext('Add Storage'),
value: '1',
},
+ PVE.SANUtils.sanViewNote(
+ gettext(
+ 'On a SAN LUN, Add Storage creates a shared storage for all nodes. For multipath or a node restriction, use Guided Setup in {0}.',
+ ),
+ ),
],
});
diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index c3b75d4be..76ed8310a 100644
--- a/www/manager6/storage/Base.js
+++ b/www/manager6/storage/Base.js
@@ -143,6 +143,11 @@ Ext.define('PVE.panel.StorageBase', {
me.advancedColumn1 = [];
}
+ // the add dialog of a SAN storage points to the guided setups of the SAN view
+ if (me.isCreate && me.sanNote) {
+ me.columnB = [...(me.columnB ?? []), PVE.SANUtils.sanViewNote(me.sanNote)];
+ }
+
me.callParent();
},
});
diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
index 7929a13b3..c20aa2896 100644
--- a/www/manager6/storage/IScsiEdit.js
+++ b/www/manager6/storage/IScsiEdit.js
@@ -77,6 +77,9 @@ Ext.define('PVE.storage.IScsiInputPanel', {
lunContent: 'images',
+ // TRANSLATORS: "Guided Setup" is a button of the SAN view, {0} the menu path of that view.
+ sanNote: gettext('To set up shared LVM with multipath on a LUN, use Guided Setup in {0}.'),
+
// Loading sets the value before its original value, so use the dirty state.
updateMultipathActivation: function () {
let me = this;
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 688130b19..d3f068166 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -148,6 +148,9 @@ Ext.define('PVE.storage.LVMInputPanel', {
onlineHelp: 'storage_lvm',
+ // TRANSLATORS: "Guided Setup" is a button of the SAN view, {0} the menu path of that view.
+ sanNote: gettext('To set up shared LVM on a SAN LUN, use Guided Setup in {0}.'),
+
onGetValues: function (values) {
let me = this;
next prev parent reply other threads:[~2026-11-19 19:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 19:46 [PATCH v8 cluster,storage,docs,manager 00/43] SAN: cluster-wide multipath, SAN views and a guided setup for shared LVM Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 cluster 01/43] cfs: observe the multipath configuration files Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 02/43] diskmanage: collect disk transport type from lsblk Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 03/43] diskmanage: qualify NVMe over Fabrics transport Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 04/43] diskmanage: optionally include iSCSI session devices in disk enumeration Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 05/43] diskmanage: collect native NVMe multipath path state Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 06/43] iscsi: factor out session device map from device list Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 07/43] multipath: add a library around multipathd Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 08/43] diskmanage: add helper to list multipath devices Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 09/43] multipath: add a cluster-wide configuration Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 10/43] iscsi: add an option to manage storage LUNs with multipath Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 11/43] lvm: activate a missing base volume before using the volume group Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 12/43] multipath: apply the configuration on every node Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 13/43] multipath: publish per-node status Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 14/43] api: add endpoints for the cluster-wide multipath configuration Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 15/43] api: multipath: add the cluster-wide health status Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 16/43] diskmanage: look up the requested disks by name Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 17/43] diskmanage: read the udev data of all disks with one call Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 18/43] api: scan: add a SAN LUN inventory Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 19/43] pvesm: expose the " Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 20/43] api: add node-level iSCSI status Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 21/43] api: scan: name the portal of an iSCSI path Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 22/43] disks: lvm: drop unused imports Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 23/43] disks: lvm: allow volume groups on SAN LUNs and multipath maps Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 24/43] disks: lvm: refuse to destroy the volume group of a shared storage Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 25/43] disks: allow wiping a SAN LUN that no storage uses Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 storage 26/43] api: scan: report the process that has a SAN LUN open Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 docs 27/43] storage: document the cluster-wide multipath management Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 docs 28/43] storage: multipath: describe the use shown for an open LUN Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 29/43] pvestatd: apply the multipath configuration and report the node status Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 30/43] report: add the managed multipath configuration Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 31/43] api: cluster: add the multipath endpoints Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 32/43] api: nodes: expose the iSCSI status Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 33/43] ui: dc: add a SAN view Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 34/43] ui: storage: iscsi: add the multipath option Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 35/43] ui: lvm: enable shared when a base storage is selected Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 36/43] ui: node: add SAN LUNs panel Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 37/43] ui: node: san: wipe a LUN that no storage uses Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 38/43] ui: node: san: show iSCSI targets and sessions Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 39/43] ui: dc: san: add a guided setup for shared LVM on iSCSI Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 40/43] ui: dc: san: add a guided setup for shared LVM on Fibre Channel Thomas Lamprecht
2026-11-19 19:46 ` Thomas Lamprecht [this message]
2026-11-19 19:46 ` [PATCH v8 manager 42/43] ui: san: show the guest or process that has a LUN open Thomas Lamprecht
2026-11-19 19:46 ` [PATCH v8 manager 43/43] ui: node: san: add a column for the target or subsystem of a LUN Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119194655.3163258-42-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox