From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 15FF11FF0DA for ; Thu, 19 Nov 2026 20:53:05 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C7EF121E23; Thu, 19 Nov 2026 20:48:40 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v8 manager 41/43] ui: storage: point the iSCSI and LVM add dialogs to the SAN view Date: Thu, 19 Nov 2026 20:46:46 +0100 Message-ID: <20261119194655.3163258-42-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119194655.3163258-1-t.lamprecht@proxmox.com> References: <20261119194655.3163258-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795117623806 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.150 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6YJ6M7PWCDN6YJPJZHLMC6RHB4X5LKX7 X-Message-ID-Hash: 6YJ6M7PWCDN6YJPJZHLMC6RHB4X5LKX7 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Admins new to Proxmox VE look for adding their SAN under Datacenter > Storage > Add. There, the iSCSI dialog connects a target without a volume group on top and, by default, without multipath. So they end up with neither a storage that can allocate guest disks nor path redundancy. The guided setups that do both are in the SAN view, which nothing in these dialogs mentions. Add a note that names the SAN view to the add dialogs of iSCSI and LVM, which stay as they are for attaching existing targets and volume groups. The dialog that creates a volume group under Node > Disks gets a note too, which says that on a SAN LUN its Add Storage option adds a shared storage for all nodes. It adds no multipath entry, so for a Fibre Channel LUN without a map, the volume group lands on a single path. Signed-off-by: Thomas Lamprecht --- www/manager6/SANUtils.js | 38 +++++++++++++++++++++++++++++++ www/manager6/node/LVM.js | 5 ++++ www/manager6/storage/Base.js | 5 ++++ www/manager6/storage/IScsiEdit.js | 3 +++ www/manager6/storage/LVMEdit.js | 3 +++ 5 files changed, 54 insertions(+) diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js index 5cd8abd76..84d482f36 100644 --- a/www/manager6/SANUtils.js +++ b/www/manager6/SANUtils.js @@ -153,6 +153,44 @@ Ext.define('PVE.SANUtils', { ); }, + // Selects Datacenter > Storage > SAN, as the TFA entry of the user menu does for its panel. + showSANView: function () { + Ext.state.Manager.getProvider().set('dctab', { value: 'san' }, true); + Ext.ComponentQuery.query('pveStdWorkspace')[0]?.selectById('root'); + }, + + // A note for the add dialogs of storages on a SAN, which points to the guided setups of the + // SAN view. Its link closes the dialog and opens the view. + sanViewNote: function (text) { + let path = `${gettext('Datacenter')} > ${gettext('Storage')} > SAN`; + let link = `${Ext.htmlEncode(path)}`; + return { + xtype: 'component', + margin: '5 0 0 0', + html: + `${Ext.htmlEncode(gettext('Note:'))} ` + + Ext.String.format(Ext.htmlEncode(text), link), + listeners: { + afterrender: function (cmp) { + let follow = function (event) { + event.stopEvent(); + cmp.up('window')?.close(); + PVE.SANUtils.showSANView(); + }; + cmp.mon(cmp.getEl(), 'click', follow, null, { delegate: 'a' }); + // an edit window handles Enter for its default button, so no click follows it + cmp.mon( + cmp.getEl(), + 'keydown', + (event) => event.getKey() === event.ENTER && follow(event), + null, + { delegate: 'a' }, + ); + }, + }, + }; + }, + renderSanTransport: function (value) { return Ext.htmlEncode( { diff --git a/www/manager6/node/LVM.js b/www/manager6/node/LVM.js index 11b03612d..ffd432fd5 100644 --- a/www/manager6/node/LVM.js +++ b/www/manager6/node/LVM.js @@ -42,6 +42,11 @@ Ext.define('PVE.node.CreateLVM', { fieldLabel: gettext('Add Storage'), value: '1', }, + PVE.SANUtils.sanViewNote( + gettext( + 'On a SAN LUN, Add Storage creates a shared storage for all nodes. For multipath or a node restriction, use Guided Setup in {0}.', + ), + ), ], }); diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js index c3b75d4be..76ed8310a 100644 --- a/www/manager6/storage/Base.js +++ b/www/manager6/storage/Base.js @@ -143,6 +143,11 @@ Ext.define('PVE.panel.StorageBase', { me.advancedColumn1 = []; } + // the add dialog of a SAN storage points to the guided setups of the SAN view + if (me.isCreate && me.sanNote) { + me.columnB = [...(me.columnB ?? []), PVE.SANUtils.sanViewNote(me.sanNote)]; + } + me.callParent(); }, }); diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js index 7929a13b3..c20aa2896 100644 --- a/www/manager6/storage/IScsiEdit.js +++ b/www/manager6/storage/IScsiEdit.js @@ -77,6 +77,9 @@ Ext.define('PVE.storage.IScsiInputPanel', { lunContent: 'images', + // TRANSLATORS: "Guided Setup" is a button of the SAN view, {0} the menu path of that view. + sanNote: gettext('To set up shared LVM with multipath on a LUN, use Guided Setup in {0}.'), + // Loading sets the value before its original value, so use the dirty state. updateMultipathActivation: function () { let me = this; diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js index 688130b19..d3f068166 100644 --- a/www/manager6/storage/LVMEdit.js +++ b/www/manager6/storage/LVMEdit.js @@ -148,6 +148,9 @@ Ext.define('PVE.storage.LVMInputPanel', { onlineHelp: 'storage_lvm', + // TRANSLATORS: "Guided Setup" is a button of the SAN view, {0} the menu path of that view. + sanNote: gettext('To set up shared LVM on a SAN LUN, use Guided Setup in {0}.'), + onGetValues: function (values) { let me = this;