Re: [PATCH proxmox-yew-comp/widget-toolkit v3 0/4] i18n: add Greek and Irish translations

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Dominik Csapak <d.csapak@proxmox.com> writes:

> just a question, is it really necessary to import extjs weirdness into
> our yew components? couldn't we simply use 'el' for greek (as
> it's the right iso code and fits with the rest?)  we might need
> to export both (at least for as long we have extjs uis).

If desired, we could add back the patch for extjs adding `el` (just
copying the files for the el_GR locale) as a new locale. I am not
familiar enough with the differences between greek in Greece and in
Cyprus (or if there are more greek speaking countries) to comment on
whether this is a good idea.

Also note that gettext does not use iso codes for languages, but rather
{iso_code}_{country_code}, so el_GR is fine [1].

[1] https://www.gnu.org/software/gettext/manual/html_node/Locale-Names.html

>
> I don't really like to import cruft/quirks from extjs here, except if

As above this is probably not a quirk.

Since `el` only came up in previous versions (at the time I tough it was
a extjs quirk) of the series and the code is valid, I did not consider
it interesting enough to mention it here.

> there is a hard technical reason, but i'm missing that. the commit messages are
> rather short :(

-- 
Maximiliano