Re: [PATCH proxmox-yew-comp/widget-toolkit v3 0/4] i18n: add Greek and Irish translations

[Dominik Csapak <d.csapak@proxmox.com>]

On 7/3/26 11:02 PM, Thomas Lamprecht wrote:
> Am 22.06.26 um 14:02 schrieb Dominik Csapak:
>> On 6/22/26 1:48 PM, Maximiliano Sandoval wrote:
>>> Dominik Csapak <d.csapak@proxmox.com> writes:
>>>
>>>> just a question, is it really necessary to import extjs weirdness into
>>>> our yew components? couldn't we simply use 'el' for greek (as
>>>> it's the right iso code and fits with the rest?)  we might need
>>>> to export both (at least for as long we have extjs uis).
>>>
>>> If desired, we could add back the patch for extjs adding `el` (just
>>> copying the files for the el_GR locale) as a new locale. I am not
>>> familiar enough with the differences between greek in Greece and in
>>> Cyprus (or if there are more greek speaking countries) to comment on
>>> whether this is a good idea.
>>
>> what i meant was in i18n we could export both 'el' (for yew) and 'el_GR' (for extjs), wouldn't that be possible?
> 
> Diverging code/source over some maybe (!) technical correct is not worth it.
> 
>>> Also note that gettext does not use iso codes for languages, but rather
>>> {iso_code}_{country_code}, so el_GR is fine [1].
>>>
>>> [1] https://www.gnu.org/software/gettext/manual/html_node/Locale-Names.html
>>
>> can be fine, but i'd like to have it consistent in yew, currently this
>> is only done for languages that need it (pt_BR, zh_CN, etc.)
>>
>> In case of greek there is only one greek language (ancient greek is iso code 'grc' [0])
>>
>> I just don't like to do such things "just because extjs does it"
> 
> I mean, it is fine by gettext and this is internal anyway, no user will ever
> see the used code directly, so any accepted one is fine to me; even if maybe
> not the most canonical variant. So this is IMO _really_ not a hill worth
> fighting on.

No problem, I didn't want to block the change as a whole. If you think
this "diversion" is ok, then we can include it ;)