public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-yew-comp/widget-toolkit v3 0/4] i18n: add Greek and Irish translations
Date: Mon, 22 Jun 2026 14:15:43 +0200	[thread overview]
Message-ID: <s8oqzlypy8g.fsf@toolbox> (raw)
In-Reply-To: <4dece4a3-9591-4b04-8665-f89fcf11ad39@proxmox.com> (Dominik Csapak's message of "Mon, 22 Jun 2026 14:02:16 +0200")

Dominik Csapak <d.csapak@proxmox.com> writes:

> On 6/22/26 1:48 PM, Maximiliano Sandoval wrote:
>> Dominik Csapak <d.csapak@proxmox.com> writes:
>> 
>>> just a question, is it really necessary to import extjs weirdness into
>>> our yew components? couldn't we simply use 'el' for greek (as
>>> it's the right iso code and fits with the rest?)  we might need
>>> to export both (at least for as long we have extjs uis).
>> If desired, we could add back the patch for extjs adding `el` (just
>> copying the files for the el_GR locale) as a new locale. I am not
>> familiar enough with the differences between greek in Greece and in
>> Cyprus (or if there are more greek speaking countries) to comment on
>> whether this is a good idea.
>
> what i meant was in i18n we could export both 'el' (for yew) and 'el_GR' (for
> extjs), wouldn't that be possible?
>

I am not sure I follow.

One thing we could do is to present `el_GR` simply as "Greek" instead of
"Greek (Greece)". The code can be treated as an implementation detail
for now.

>> Also note that gettext does not use iso codes for languages, but rather
>> {iso_code}_{country_code}, so el_GR is fine [1].
>> [1] https://www.gnu.org/software/gettext/manual/html_node/Locale-Names.html
>
> can be fine, but i'd like to have it consistent in yew, currently this
> is only done for languages that need it (pt_BR, zh_CN, etc.)
>
> In case of greek there is only one greek language (ancient greek is iso code
> 'grc' [0])

The same language can have multiple "locale codes" for the purposes of
gettext. There are platforms where en_GB (or es_MX) are translated
differently than `en` (or `es`).

> I just don't like to do such things "just because extjs does it"

for what it is worth, GNOME only has `el` code for Greek.

[1] https://l10n.gnome.org/languages/

> Though if it's very hard to implement, it's fine, but then i'd like
> to have that reason in the commit message ;)
>

See https://git.proxmox.com/?p=extjs.git;a=commit;h=4f893504d8a8e135461ce94d50f261584f769c4e.

>> 
>>>
>>> I don't really like to import cruft/quirks from extjs here, except if
>> As above this is probably not a quirk.
>> Since `el` only came up in previous versions (at the time I tough it was
>> a extjs quirk) of the series and the code is valid, I did not consider
>> it interesting enough to mention it here.
>> 
>>> there is a hard technical reason, but i'm missing that. the commit messages are
>>> rather short :(
>> 
>
> 0: https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes

-- 
Maximiliano




  reply	other threads:[~2026-06-22 12:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 11:32 [PATCH proxmox-yew-comp/widget-toolkit v3 0/4] i18n: add Greek and Irish translations Maximiliano Sandoval
2026-06-22 11:32 ` [PATCH proxmox-yew-comp v3 1/4] language map: add Greek as available language Maximiliano Sandoval
2026-06-22 11:32 ` [PATCH proxmox-yew-comp v3 2/4] language map: add Irish " Maximiliano Sandoval
2026-06-22 11:32 ` [PATCH widget-toolkit v3 3/4] language map: add Greek " Maximiliano Sandoval
2026-06-22 11:33 ` [PATCH widget-toolkit v3 4/4] language map: add Irish " Maximiliano Sandoval
2026-06-22 11:37 ` [PATCH proxmox-yew-comp/widget-toolkit v3 0/4] i18n: add Greek and Irish translations Dominik Csapak
2026-06-22 11:49   ` Maximiliano Sandoval
2026-06-22 12:02     ` Dominik Csapak
2026-06-22 12:15       ` Maximiliano Sandoval [this message]
2026-06-22 13:25         ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s8oqzlypy8g.fsf@toolbox \
    --to=m.sandoval@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal