From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7272B1FF153 for ; Mon, 22 Jun 2026 13:49:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 744E59ABF; Mon, 22 Jun 2026 13:49:38 +0200 (CEST) From: Maximiliano Sandoval To: Dominik Csapak Subject: Re: [PATCH proxmox-yew-comp/widget-toolkit v3 0/4] i18n: add Greek and Irish translations In-Reply-To: <077b9442-cf9b-4a57-902c-dd1b8bce6ce5@proxmox.com> (Dominik Csapak's message of "Mon, 22 Jun 2026 13:37:14 +0200") References: <20260622113303.348962-1-m.sandoval@proxmox.com> <077b9442-cf9b-4a57-902c-dd1b8bce6ce5@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Mon, 22 Jun 2026 13:49:02 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782128932884 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UCMNGRPBGTEXR7TSQHLAWSLJ5ABC65YV X-Message-ID-Hash: UCMNGRPBGTEXR7TSQHLAWSLJ5ABC65YV X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dominik Csapak writes: > just a question, is it really necessary to import extjs weirdness into > our yew components? couldn't we simply use 'el' for greek (as > it's the right iso code and fits with the rest?) we might need > to export both (at least for as long we have extjs uis). If desired, we could add back the patch for extjs adding `el` (just copying the files for the el_GR locale) as a new locale. I am not familiar enough with the differences between greek in Greece and in Cyprus (or if there are more greek speaking countries) to comment on whether this is a good idea. Also note that gettext does not use iso codes for languages, but rather {iso_code}_{country_code}, so el_GR is fine [1]. [1] https://www.gnu.org/software/gettext/manual/html_node/Locale-Names.html > > I don't really like to import cruft/quirks from extjs here, except if As above this is probably not a quirk. Since `el` only came up in previous versions (at the time I tough it was a extjs quirk) of the series and the code is valid, I did not consider it interesting enough to mention it here. > there is a hard technical reason, but i'm missing that. the commit messages are > rather short :( -- Maximiliano