Re: [PATCH v2 pve-storage 2/16] test: get_subdir: cover the efi-firmware content type

[Fiona Ebner <f.ebner@proxmox.com>]

Am 28.09.26 um 7:48 AM schrieb Christian Ludwig:
> Check that the vtype maps to the efi-firmware/ subdirectory.
> 
> Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
> ---
>  src/test/get_subdir_test.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/test/get_subdir_test.pm b/src/test/get_subdir_test.pm
> index 5fb5445..5be6de8 100644
> --- a/src/test/get_subdir_test.pm
> +++ b/src/test/get_subdir_test.pm
> @@ -19,6 +19,8 @@ my $tests = [
>      # failed matches
>      [$scfg_with_path, 'none', "unknown vtype 'none'\n"],
>      [{}, 'iso', "storage definition has no path\n"],
> +    # efi-firmware vtype returns <path>/efi-firmware
> +    [$scfg_with_path, 'efi-firmware', "$scfg_with_path->{path}/efi-firmware"],
>  ];
>  
>  # creates additional positive tests

It's already covered by the tests here like other content types, but it
also doesn't hurt to have it be explicit, so:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>