public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH v2 pve-manager 13/16] ui: form: support other content types in the ISO selector
Date: Mon, 28 Sep 2026 07:48:16 +0200	[thread overview]
Message-ID: <0ef5d24516aee0659479863de81cef1012cda74e.1790337878.git@genua.de> (raw)
In-Reply-To: <cover.1790337423.git@genua.de>

The selector pairs a storage selector with a file selector and keeps
both in sync, which is useful for any content type, not just ISO images.
Filter both lists by the 'storageContent' config. The file selector
label gets configured via 'fileLabel'.

The defaults keep the existing ISO behavior.

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 www/manager6/form/IsoSelector.js | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js
index b2d94ed3..508c0eaf 100644
--- a/www/manager6/form/IsoSelector.js
+++ b/www/manager6/form/IsoSelector.js
@@ -13,11 +13,17 @@ Ext.define('PVE.form.IsoSelector', {
     labelWidth: undefined,
     labelAlign: 'right',
 
+    // Storage content type to select from, default: iso.
+    storageContent: 'iso',
+    fileLabel: gettext('ISO image'),
+
     cbindData: function () {
         let me = this;
         return {
             nodename: me.nodename,
             insideWizard: me.insideWizard,
+            storageContent: me.storageContent,
+            fieldLabel: me.fileLabel,
         };
     },
 
@@ -71,9 +77,9 @@ Ext.define('PVE.form.IsoSelector', {
             reference: 'storage',
             isFormField: false,
             fieldLabel: gettext('Storage'),
-            storageContent: 'iso',
             allowBlank: false,
             cbind: {
+                storageContent: '{storageContent}',
                 nodename: '{nodename}',
                 autoSelect: '{insideWizard}',
                 insideWizard: '{insideWizard}',
@@ -94,10 +100,10 @@ Ext.define('PVE.form.IsoSelector', {
             xtype: 'pveFileSelector',
             reference: 'file',
             isFormField: false,
-            storageContent: 'iso',
-            fieldLabel: gettext('ISO image'),
             labelAlign: 'right',
             cbind: {
+                storageContent: '{storageContent}',
+                fieldLabel: '{fieldLabel}',
                 nodename: '{nodename}',
                 disabled: '{disabled}',
                 labelWidth: '{labelWidth}',
-- 
2.34.1




  parent reply	other threads:[~2026-09-28  5:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  5:47 [PATCH v2 0/16] Support for custom EFI firmware Christian Ludwig
2026-09-28  5:47 ` [PATCH v2 pve-storage 1/16] plugin: add efi-firmware content type Christian Ludwig
2026-09-28  5:47 ` [PATCH v2 pve-storage 2/16] test: get_subdir: cover the " Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 3/16] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 4/16] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 5/16] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 6/16] test: list volumes: " Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 07/16] config: add the efi-firmware option Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 08/16] api: allow setting " Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 09/16] ovmf: use a custom firmware image if configured Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 10/16] test: efi-firmware key in VM config Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 11/16] test: efi-firmware volumes replication Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-manager 12/16] ui: storage: add efi-firmware content type support Christian Ludwig
2026-09-28  5:48 ` Christian Ludwig [this message]
2026-09-28  5:48 ` [PATCH v2 pve-manager 14/16] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-docs 15/16] pvesm: document the efi-firmware content type Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-docs 16/16] qm: document the efi-firmware VM option Christian Ludwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef5d24516aee0659479863de81cef1012cda74e.1790337878.git@genua.de \
    --to=christian_ludwig@genua.de \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal