public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH v2 pve-manager 12/16] ui: storage: add efi-firmware content type support
Date: Mon, 28 Sep 2026 07:48:15 +0200	[thread overview]
Message-ID: <58bf4f3696b49626156e812e4e80e23105995bd5.1790337878.git@genua.de> (raw)
In-Reply-To: <cover.1790337423.git@genua.de>

Add the 'efi-firmware' storage content type to the Web UI:

- Utils.js: add display name for the content type
- ContentTypeSelector: include in the default content type list
- CephFSEdit: include in its explicit content type list, the backend
  CephFS plugin allows the type as well
- Browser: add a tab for browsing and uploading firmware images; the
  format is always 'raw' for this type, so drop that column
- UploadToStorage: allow uploading files without extension restrictions,
  the backend validates the file name by character class instead of by
  extension

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 www/manager6/Utils.js                    |  1 +
 www/manager6/form/ContentTypeSelector.js | 11 ++++++++++-
 www/manager6/storage/Browser.js          | 14 ++++++++++++++
 www/manager6/storage/CephFSEdit.js       |  2 +-
 www/manager6/window/UploadToStorage.js   |  1 +
 5 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index c86a00c5..1f1be06b 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -740,6 +740,7 @@ Ext.define('PVE.Utils', {
             rootdir: gettext('Container'),
             snippets: gettext('Snippets'),
             import: gettext('Import'),
+            'efi-firmware': gettext('EFI Firmware'),
         },
 
         // volume can be a full volume info object, in which case the format parameter is ignored, or
diff --git a/www/manager6/form/ContentTypeSelector.js b/www/manager6/form/ContentTypeSelector.js
index 60532251..b33eb124 100644
--- a/www/manager6/form/ContentTypeSelector.js
+++ b/www/manager6/form/ContentTypeSelector.js
@@ -10,7 +10,16 @@ Ext.define('PVE.form.ContentTypeSelector', {
         me.comboItems = [];
 
         if (me.cts === undefined) {
-            me.cts = ['images', 'iso', 'vztmpl', 'backup', 'rootdir', 'snippets', 'import'];
+            me.cts = [
+                'images',
+                'iso',
+                'vztmpl',
+                'backup',
+                'rootdir',
+                'snippets',
+                'import',
+                'efi-firmware',
+            ];
         }
 
         Ext.Array.each(me.cts, function (ct) {
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index d0237948..611c0009 100644
--- a/www/manager6/storage/Browser.js
+++ b/www/manager6/storage/Browser.js
@@ -189,6 +189,20 @@ Ext.define('PVE.storage.Browser', {
                     pluginType: plugin,
                 });
             }
+            if (contents.includes('efi-firmware')) {
+                me.items.push({
+                    xtype: 'pveStorageContentView',
+                    title: gettext('EFI Firmware'),
+                    iconCls: 'fa fa-microchip',
+                    itemId: 'contentEfiFirmware',
+                    content: 'efi-firmware',
+                    showColumns: ['name', 'date', 'size'],
+                    pluginType: plugin,
+                    enableUploadButton: enableUpload,
+                    enableDownloadUrlButton: enableDownloadUrl,
+                    useUploadButton: true,
+                });
+            }
         }
 
         if (caps.storage['Permissions.Modify']) {
diff --git a/www/manager6/storage/CephFSEdit.js b/www/manager6/storage/CephFSEdit.js
index db54df87..3b7a49f3 100644
--- a/www/manager6/storage/CephFSEdit.js
+++ b/www/manager6/storage/CephFSEdit.js
@@ -95,7 +95,7 @@ Ext.define('PVE.storage.CephFSInputPanel', {
         me.column2 = [
             {
                 xtype: 'pveContentTypeSelector',
-                cts: ['backup', 'iso', 'vztmpl', 'snippets', 'import'],
+                cts: ['backup', 'iso', 'vztmpl', 'snippets', 'import', 'efi-firmware'],
                 fieldLabel: gettext('Content'),
                 name: 'content',
                 value: 'backup',
diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js
index cc53596d..3897334d 100644
--- a/www/manager6/window/UploadToStorage.js
+++ b/www/manager6/window/UploadToStorage.js
@@ -12,6 +12,7 @@ Ext.define('PVE.window.UploadToStorage', {
         import: ['.ova', '.qcow2', '.raw', '.vmdk'],
         iso: ['.img', '.iso'],
         vztmpl: ['.tar.gz', '.tar.xz', '.tar.zst'],
+        'efi-firmware': [],
     },
 
     // accepted for file selection, will be renamed to real extension
-- 
2.34.1




  parent reply	other threads:[~2026-09-28  5:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  5:47 [PATCH v2 0/16] Support for custom EFI firmware Christian Ludwig
2026-09-28  5:47 ` [PATCH v2 pve-storage 1/16] plugin: add efi-firmware content type Christian Ludwig
2026-09-28  5:47 ` [PATCH v2 pve-storage 2/16] test: get_subdir: cover the " Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 3/16] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 4/16] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 5/16] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-storage 6/16] test: list volumes: " Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 07/16] config: add the efi-firmware option Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 08/16] api: allow setting " Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 09/16] ovmf: use a custom firmware image if configured Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 10/16] test: efi-firmware key in VM config Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 qemu-server 11/16] test: efi-firmware volumes replication Christian Ludwig
2026-09-28  5:48 ` Christian Ludwig [this message]
2026-09-28  5:48 ` [PATCH v2 pve-manager 13/16] ui: form: support other content types in the ISO selector Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-manager 14/16] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-docs 15/16] pvesm: document the efi-firmware content type Christian Ludwig
2026-09-28  5:48 ` [PATCH v2 pve-docs 16/16] qm: document the efi-firmware VM option Christian Ludwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58bf4f3696b49626156e812e4e80e23105995bd5.1790337878.git@genua.de \
    --to=christian_ludwig@genua.de \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal