From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 65E611FF09C for ; Mon, 05 Oct 2026 16:37:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0B33521677; Mon, 05 Oct 2026 16:37:02 +0200 (CEST) Message-ID: Date: Mon, 5 Oct 2026 16:36:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 pve-storage 2/16] test: get_subdir: cover the efi-firmware content type To: Christian Ludwig , pve-devel@lists.proxmox.com References: Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791211016707 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.473 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BB4BOGA6ZACDLSDBPCG2Y2ABYL6DKR73 X-Message-ID-Hash: BB4BOGA6ZACDLSDBPCG2Y2ABYL6DKR73 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 28.09.26 um 7:48 AM schrieb Christian Ludwig: > Check that the vtype maps to the efi-firmware/ subdirectory. > > Signed-off-by: Christian Ludwig > --- > src/test/get_subdir_test.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/test/get_subdir_test.pm b/src/test/get_subdir_test.pm > index 5fb5445..5be6de8 100644 > --- a/src/test/get_subdir_test.pm > +++ b/src/test/get_subdir_test.pm > @@ -19,6 +19,8 @@ my $tests = [ > # failed matches > [$scfg_with_path, 'none', "unknown vtype 'none'\n"], > [{}, 'iso', "storage definition has no path\n"], > + # efi-firmware vtype returns /efi-firmware > + [$scfg_with_path, 'efi-firmware', "$scfg_with_path->{path}/efi-firmware"], > ]; > > # creates additional positive tests It's already covered by the tests here like other content types, but it also doesn't hurt to have it be explicit, so: Reviewed-by: Fiona Ebner