Re: [PATCH v2 pve-storage 6/16] test: list volumes: cover efi-firmware volumes

[Fiona Ebner <f.ebner@proxmox.com>]

Am 28.09.26 um 7:48 AM schrieb Christian Ludwig:
> Check that files in efi-firmware/ are listed as efi-firmware volumes,
> regardless of their extension.
> 
> Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
> ---
>  src/test/list_volumes_test.pm | 51 ++++++++++++++++++++++++++++++++++-
>  1 file changed, 50 insertions(+), 1 deletion(-)
> 
> diff --git a/src/test/list_volumes_test.pm b/src/test/list_volumes_test.pm
> index 0876902..a1e98d1 100644
> --- a/src/test/list_volumes_test.pm
> +++ b/src/test/list_volumes_test.pm
> @@ -72,6 +72,7 @@ my $scfg = {
>          'images' => 1,
>          'snippets' => 1,
>          'backup' => 1,
> +        'efi-firmware' => 1,
>      },
>  };
>  
> @@ -462,6 +463,54 @@ my @tests = (
>          ],
>          expected => [], # returns empty list
>      },
> +    {
> +        description => 'VMID: none, efi-firmware .fd files listed',
> +        vmid => undef,
> +        files => [
> +            "$storage_dir/efi-firmware/custom.fd",
> +            "$storage_dir/efi-firmware/vendor-bios-v2.fd",
> +        ],
> +        expected => [
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/custom.fd',
> +            },
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/vendor-bios-v2.fd',
> +            },
> +        ],
> +    },
> +    {
> +        description => 'VMID: none, all efi-firmware files listed regardless of extension',

Note: might need to be adapted depending on what we decide regarding
extension restriction.

> +        vmid => undef,
> +        files => [
> +            "$storage_dir/efi-firmware/custom.fd",
> +            "$storage_dir/efi-firmware/custom.iso",
> +        ],
> +        expected => [
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/custom.fd',
> +            },
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/custom.iso',
> +            },
> +        ],
> +    },
>  );
>  
>  # provide static vmlist for tests
> @@ -520,7 +569,7 @@ plan tests => $plan + 1;
>  
>  {
>      my $sid = 'local';
> -    my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets'];
> +    my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets', 'efi-firmware'];
>      my @suffixes = ('qcow2', 'raw', 'vmdk', 'vhdx');
>  
>      # run through test cases