From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 2B6C41FF09C
	for <inbox@lore.proxmox.com>; Mon, 05 Oct 2026 16:37:44 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 68EF621718;
	Mon, 05 Oct 2026 16:37:25 +0200 (CEST)
Message-ID: <8a953329-3328-403f-a9f0-e2b343880983@proxmox.com>
Date: Mon, 5 Oct 2026 16:37:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 pve-storage 6/16] test: list volumes: cover
 efi-firmware volumes
To: Christian Ludwig <christian_ludwig@genua.de>, pve-devel@lists.proxmox.com
References: <cover.1790337423.git@genua.de>
 <9bc12cf44b8fb79ec2eba4f4eb836374dd63965e.1790337423.git@genua.de>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: 
 <9bc12cf44b8fb79ec2eba4f4eb836374dd63965e.1790337423.git@genua.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1791211034454
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.469 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: FO2SM6SW3GXDCI7Y7CCN2AYFG2Z5OGUK
X-Message-ID-Hash: FO2SM6SW3GXDCI7Y7CCN2AYFG2Z5OGUK
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 28.09.26 um 7:48 AM schrieb Christian Ludwig:
> Check that files in efi-firmware/ are listed as efi-firmware volumes,
> regardless of their extension.
> 
> Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
> ---
>  src/test/list_volumes_test.pm | 51 ++++++++++++++++++++++++++++++++++-
>  1 file changed, 50 insertions(+), 1 deletion(-)
> 
> diff --git a/src/test/list_volumes_test.pm b/src/test/list_volumes_test.pm
> index 0876902..a1e98d1 100644
> --- a/src/test/list_volumes_test.pm
> +++ b/src/test/list_volumes_test.pm
> @@ -72,6 +72,7 @@ my $scfg = {
>          'images' => 1,
>          'snippets' => 1,
>          'backup' => 1,
> +        'efi-firmware' => 1,
>      },
>  };
>  
> @@ -462,6 +463,54 @@ my @tests = (
>          ],
>          expected => [], # returns empty list
>      },
> +    {
> +        description => 'VMID: none, efi-firmware .fd files listed',
> +        vmid => undef,
> +        files => [
> +            "$storage_dir/efi-firmware/custom.fd",
> +            "$storage_dir/efi-firmware/vendor-bios-v2.fd",
> +        ],
> +        expected => [
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/custom.fd',
> +            },
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/vendor-bios-v2.fd',
> +            },
> +        ],
> +    },
> +    {
> +        description => 'VMID: none, all efi-firmware files listed regardless of extension',

Note: might need to be adapted depending on what we decide regarding
extension restriction.

> +        vmid => undef,
> +        files => [
> +            "$storage_dir/efi-firmware/custom.fd",
> +            "$storage_dir/efi-firmware/custom.iso",
> +        ],
> +        expected => [
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/custom.fd',
> +            },
> +            {
> +                'content' => 'efi-firmware',
> +                'ctime' => DEFAULT_CTIME,
> +                'format' => 'raw',
> +                'size' => DEFAULT_SIZE,
> +                'volid' => 'local:efi-firmware/custom.iso',
> +            },
> +        ],
> +    },
>  );
>  
>  # provide static vmlist for tests
> @@ -520,7 +569,7 @@ plan tests => $plan + 1;
>  
>  {
>      my $sid = 'local';
> -    my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets'];
> +    my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets', 'efi-firmware'];
>      my @suffixes = ('qcow2', 'raw', 'vmdk', 'vhdx');
>  
>      # run through test cases