public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode
@ 2026-11-13 15:26 Dominik Rusovac
  2026-11-13 15:26 ` [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set " Dominik Rusovac
                   ` (4 more replies)
  0 siblings, 5 replies; 13+ messages in thread
From: Dominik Rusovac @ 2026-11-13 15:26 UTC (permalink / raw)
  To: pve-devel

this picks up Thomas' v3 [0], rebased onto current master and reworked in a few
places; thx for the nice work Thomas! I added `Originally-by` trailers

node maintenance mode can currently only be enabled/disabled with the HA
manager's CRM command in the CLI. this series adds an API endpoint and a 'Node
Maintenance' menu in the HA status panel for it

the endpoint lives at PUT /nodes/{node}/maintenance in pve-manager, as agreed
on in the v1/v2 reviews, so that the maintenance concept can be extended beyond
HA managed resources later on. for now, it just queues the same CRM command as
the CLI. it rejects nodes unknown to the HA stack as well as enabling
maintenance mode while HA is disarmed or if the node is not online from the
CRM's point of view, since the CRM would ignore such requests

to decide which action to offer, the UI uses the maintenance request recorded
by the CRM, which the HA status API now reports, instead of the mode the LRM
reports. the LRM also enters maintenance mode on shutdown with the 'migrate'
shutdown policy, which a disable request cannot undo

the UI patch (2/4) depends on the pve-ha-manager patch (3/4), as it uses the
maintenance request reported by the HA status API, so pve-manager needs a
bumped dependency on pve-ha-manager

basic functionality was tested in a virtualized 3-node cluster:
* enabling/disabling worked as expected
* possible actions were offered as expected

changes since v3:
* rebase onto current master, including the arm/disarm changes, which also
  added a toolbar to the HA status panel
* ha-manager: report the CRM maintenance request instead of the LRM mode
* manager: api: check Sys.Modify on /nodes/{node} instead of /, reject nodes
  unknown to HA, and reject enabling maintenance while HA is disarmed or if the
  node is not online
* manager: ui: move the menu next to Arm/Disarm, use the view model and
  controller of the HA status panel, fix selection handling, use complete
  sentences for translatable strings, show a spinner while a maintenance request
  is processed
* docs: condense the UI instructions and adapt them to the menu

[0] https://lore.proxmox.com/all/20251025183814.698627-1-thomas@atskinner.net/


pve-manager:

Dominik Rusovac (2):
  api: nodes: add endpoint to set maintenance mode
  fix #6144: ui: ha: status: allow toggling maintenance mode

 PVE/API2/Nodes.pm             |  54 ++++++++++++++++++
 www/manager6/ha/Status.js     | 102 ++++++++++++++++++++++++++++++++++
 www/manager6/ha/StatusView.js |  36 +++++++++++-
 3 files changed, 191 insertions(+), 1 deletion(-)


pve-ha-manager:

Dominik Rusovac (1):
  api: status: report node maintenance request for lrm entries

 src/PVE/API2/HA/Status.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)


pve-docs:

Dominik Rusovac (1):
  ha-manager: maintenance mode: mention web ui menu

 ha-manager.adoc | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)


Summary over all repositories:
  5 files changed, 210 insertions(+), 7 deletions(-)

-- 
Generated by murpp 0.11.0




^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-11-19 10:05 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13 15:26 [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set " Dominik Rusovac
2026-11-16 11:57   ` Daniel Kral
2026-11-17  8:58     ` Dominik Rusovac
2026-11-17  9:21       ` Daniel Kral
2026-11-17  9:40         ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-manager v4 2/4] fix #6144: ui: ha: status: allow toggling " Dominik Rusovac
2026-11-17  9:07   ` Daniel Kral
2026-11-17 11:02     ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-ha-manager v4 3/4] api: status: report node maintenance request for lrm entries Dominik Rusovac
2026-11-16 12:02   ` Daniel Kral
2026-11-13 15:26 ` [PATCH pve-docs v4 4/4] ha-manager: maintenance mode: mention web ui menu Dominik Rusovac
2026-11-19 10:05 ` [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal