From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 812381FF0AA for ; Tue, 17 Nov 2026 10:08:12 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1C23521597; Tue, 17 Nov 2026 10:08:09 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Tue, 17 Nov 2026 10:07:58 +0100 Message-Id: Subject: Re: [PATCH pve-manager v4 2/4] fix #6144: ui: ha: status: allow toggling maintenance mode From: "Daniel Kral" To: "Dominik Rusovac" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0-45-gc30c872fde7b-dirty References: <20261113152620.2662417-1-d.rusovac@proxmox.com> <20261113152620.2662417-3-d.rusovac@proxmox.com> In-Reply-To: <20261113152620.2662417-3-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794906479060 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.561 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WWUOQG5I224VZWLTR74EMUNWAHMW7VWC X-Message-ID-Hash: WWUOQG5I224VZWLTR74EMUNWAHMW7VWC X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Skinner X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Nov 13, 2026 at 4:26 PM CET, Dominik Rusovac wrote: > maintenance mode could only be enabled or disabled through the HA > manager's CLI > > add a 'Node Maintenance' menu to the HA status panel, which requests > enabling/disabling maintenance mode for the node of the selected lrm > entry > > as the CRM only processes the request on its next round, show a > spinner on the lrm entry of the node and keep the menu disabled for > it until the status reports the requested state, like it is done when > disarming HA > > enabling is not offered while HA is disarmed, as the CRM ignores such > requests in that state. menu is disabled for users lacking the > Sys.Modify privilege on nodes > > the LRM also enters maintenance mode on shutdown with the 'migrate' > shutdown policy, which a disable request would not undo > > 'fa fa-check' icon was chosen for 'Disable' option to be consistent > with which icon a node gets when coming back from maintenance mode > > Originally-by: Thomas Skinner > Signed-off-by: Dominik Rusovac > --- > > Notes: > changes since v3: > * reword commit subject and body > * move the menu into the HA status panel toolbar next to > Arm/Disarm, using its view model and controller instead of a > second toolbar > * decide the offered action based on the maintenance-requested > flag > * update the state on selection changes and store loads, which > also handles deselection > * use complete sentences for translatable strings > * show a spinner on the lrm entry while a maintenance request is > processed, like for disarming HA > * disable 'Enable' while HA is disarmed > * check Sys.Modify on nodes, matching the endpoint > > www/manager6/ha/Status.js | 102 ++++++++++++++++++++++++++++++++++ > www/manager6/ha/StatusView.js | 36 +++++++++++- > 2 files changed, 137 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/ha/Status.js b/www/manager6/ha/Status.js > index c01bd737..c040c1b2 100644 > --- a/www/manager6/ha/Status.js > +++ b/www/manager6/ha/Status.js > @@ -11,6 +11,17 @@ Ext.define('PVE.ha.Status', { > viewModel: { > data: { > haDisarmed: false, > + maintenanceNode: null, nit: 'selectedNode' describes the content a bit better; maybe even 'selectedLrmNode' > + maintenanceRequested: false, > + maintenancePending: false, These are also only true for the selectedLrmNode... But prefixing this would get rather long, so maybe just a comment, so it's clear? > + }, > + formulas: { > + noMaintenanceAction: (get) =3D> > + !get('maintenanceNode') || > + get('maintenancePending') || > + !Ext.state.Manager.get('GuiCap').nodes['Sys.Modify'], AFAIK the formula will never update if the GuiCap changes, because formulas are only updated by get()'ing view model data... Though this is probably very minor, because the GuiCaps are only set roughly whenever the user logins. And if a user logs out and logs back in again in the same session, this component seems to be reloaded anyway and therefore the formula is reevaluated as well. > + // the CRM ignores requests to enable maintenance mode while= HA is disarmed > + noMaintenanceEnable: (get) =3D> get('maintenanceRequested') = || get('haDisarmed'), > }, > }, > =20 > @@ -52,6 +63,67 @@ Ext.define('PVE.ha.Status', { > ); > }, > =20 > + updateMaintenanceState: function () { > + let me =3D this; > + let vm =3D me.getViewModel(); > + let sv =3D me.getView().down('pveHAStatusView'); > + let rec =3D sv.getSelection()[0]; > + let isLrm =3D rec?.get('type') =3D=3D=3D 'lrm'; > + > + vm.set('maintenanceNode', isLrm ? rec.get('node') : null); > + vm.set('maintenanceRequested', isLrm && rec.get('maintenance= -requested')); > + vm.set('maintenancePending', isLrm && sv.isMaintenancePendin= g(rec.get('node'))); > + }, > + > + handleMaintenanceButton: function (menuItem) { AFAIK the handlers for tbar items have the signature function (menuItem, event, record) {} i.e., record would already contain the currently selected status grid item, which would then just need to be checked against whether it is an LRM. However, since these are already used to check whether the button should be disabled/enabled at all, it seems better to stick with the current solution. Unfortunately, I didn't find the documentation (the tbar property is just documented as Object|Object[] in the ExtJS documentation ;-)), but we use it in some parts of our codebase. > + let me =3D this; > + let node =3D me.getViewModel().get('maintenanceNode'); > + if (!node) { > + return; > + } > + > + let msg; > + if (menuItem.maintenanceMode =3D=3D=3D 'disable') { > + msg =3D Ext.String.format( > + gettext("Are you sure you want to disable maintenanc= e mode for node '{0}'?"), > + node, > + ); nit: could probably be factored out with another gettext parameter for maintenanceMode being either 'disable' or 'enable'. > + if (me.getViewModel().get('haDisarmed')) { > + msg +=3D > + '

' + > + Ext.String.format( > + gettext("HA resources will be migrated back = to node '{0}' once HA is re-armed."), > + node, > + ); > + } > + } else { } else if (menuItem.maintenanceMode =3D=3D=3D 'enable') { > + msg =3D Ext.String.format( > + gettext("Are you sure you want to enable maintenance= mode for node '{0}'?"), > + node, > + ); > + msg +=3D > + '

' + > + gettext('HA resources on the node will be migrated t= o other nodes.'); > + } } else { throw "Invalid maintenance mode '...'"; } or something similar, so when another maintenance mode is added in the GUI this will be apparent on clicking it the first time. > + > + Ext.Msg.confirm(gettext('Confirm'), msg, function (btn) { > + if (btn !=3D=3D 'yes') { > + return; > + } > + Proxmox.Utils.API2Request({ > + url: `/nodes/${node}/maintenance`, > + params: { 'maintenance-mode': menuItem.maintenanceMo= de }, > + method: 'PUT', > + success: function () { > + let sv =3D me.getView().down('pveHAStatusView'); > + sv.setMaintenancePending(node, menuItem.maintena= nceMode =3D=3D=3D 'enable'); > + me.updateMaintenanceState(); > + }, > + failure: (response) =3D> Ext.Msg.alert(gettext('Erro= r'), response.htmlStatus), This should also set the maintenancePending for that node to false? Might be related to the note about when the maintenance request doesn't go to the manager_status below. > + }); > + }); > + }, > + > openCRSOptions: function () { > Ext.create('PVE.form.CRSOptions', { > autoShow: true, > @@ -121,6 +193,34 @@ Ext.define('PVE.ha.Status', { > }, > ], > }, > + '-', > + { > + text: gettext('Node Maintenance'), > + iconCls: 'fa fa-wrench', > + bind: { > + disabled: '{noMaintenanceAction}', > + }, > + menu: [ > + { > + text: gettext('Enable'), > + iconCls: 'fa fa-wrench', > + maintenanceMode: 'enable', > + bind: { > + disabled: '{noMaintenanceEnable}', > + }, > + handler: 'handleMaintenanceButton', > + }, > + { > + text: gettext('Disable'), > + iconCls: 'fa fa-check', > + maintenanceMode: 'disable', > + bind: { > + disabled: '{!maintenanceRequested}', > + }, > + handler: 'handleMaintenanceButton', > + }, > + ], > + }, > '->', > { > text: gettext('CRS Settings'), > @@ -153,11 +253,13 @@ Ext.define('PVE.ha.Status', { > collapsible: true, > padding: '0 0 20 0', > listeners: { > + selectionchange: () =3D> me.getController().updateMa= intenanceState(), > hastatuschange: function (isDisarmed) { > let vm =3D me.getViewModel(); > let sv =3D me.query('pveHAStatusView')[0]; > =20 > vm.set('haDisarmed', isDisarmed); > + me.getController().updateMaintenanceState(); > =20 > if (sv.isDisarmedPendingState =3D=3D=3D null) { > return; > diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.j= s > index f260bc0d..5e8f001e 100644 > --- a/www/manager6/ha/StatusView.js > +++ b/www/manager6/ha/StatusView.js > @@ -23,6 +23,19 @@ Ext.define( > me.getView().refresh(); > }, > =20 > + // maps node names to the expected value of their maintenance-re= quested field > + maintenancePending: null, This should already be initialized with {} > + > + setMaintenancePending: function (node, requested) { > + let me =3D this; > + me.maintenancePending[node] =3D requested; > + me.getView().refresh(); > + }, > + > + isMaintenancePending: function (node) { > + return this.maintenancePending[node] !=3D=3D undefined; > + }, > + > initComponent: function () { > var me =3D this; > =20 > @@ -30,6 +43,8 @@ Ext.define( > throw 'no rstore given'; > } > =20 > + me.maintenancePending =3D {}; > + > Proxmox.Utils.monStoreErrors(me, me.rstore); > =20 > var store =3D Ext.create('Proxmox.data.DiffStore', { > @@ -52,6 +67,18 @@ Ext.define( > }); > =20 > me.rstore.on('load', function () { > + let maintenanceDone =3D false; nit: `maintenanceRequestAccepted` would be more accurate > + for (const [node, requested] of Object.entries(me.mainte= nancePending)) { > + let rec =3D store.getById(`lrm:${node}`); > + if (!rec || rec.get('maintenance-requested') =3D=3D= =3D requested) { > + delete me.maintenancePending[node]; > + maintenanceDone =3D true; > + } > + } Found by automated review: the maintenancePending should also be removed if something hinders the maintenance request landing in the manager_status, e.g., LRM is already disarmed or offline. Even though the API handler can error and then take the error path, that's still racy because the disarm or offline node could just happen in the same exact HA Manager round... So this should be either handled additionally or check some other way whether the maintenance request is still pending. > + if (maintenanceDone) { > + me.getView().refresh(); > + } > + > let fencing =3D store.findRecord('type', 'fencing'); > let disarmed =3D fencing && fencing.get('armed-state') = =3D=3D=3D 'disarmed'; > =20 > @@ -76,7 +103,10 @@ Ext.define( > flex: 1, > dataIndex: 'status', > renderer: function (value, _metaData, rec) { > - if (rec.data.type =3D=3D=3D 'fencing' && me.= pending) { > + if ( > + (rec.data.type =3D=3D=3D 'fencing' && me= .pending) || > + (rec.data.type =3D=3D=3D 'lrm' && me.isM= aintenancePending(rec.data.node)) > + ) { > return value + ' '; > } > return value; > @@ -132,6 +162,10 @@ Ext.define( > }, > }, > 'armed-state', > + { > + name: 'maintenance-requested', > + type: 'boolean', > + }, > ], > idProperty: 'id', > });