public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Rusovac <d.rusovac@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode
Date: Fri, 13 Nov 2026 16:26:16 +0100	[thread overview]
Message-ID: <20261113152620.2662417-1-d.rusovac@proxmox.com> (raw)

this picks up Thomas' v3 [0], rebased onto current master and reworked in a few
places; thx for the nice work Thomas! I added `Originally-by` trailers

node maintenance mode can currently only be enabled/disabled with the HA
manager's CRM command in the CLI. this series adds an API endpoint and a 'Node
Maintenance' menu in the HA status panel for it

the endpoint lives at PUT /nodes/{node}/maintenance in pve-manager, as agreed
on in the v1/v2 reviews, so that the maintenance concept can be extended beyond
HA managed resources later on. for now, it just queues the same CRM command as
the CLI. it rejects nodes unknown to the HA stack as well as enabling
maintenance mode while HA is disarmed or if the node is not online from the
CRM's point of view, since the CRM would ignore such requests

to decide which action to offer, the UI uses the maintenance request recorded
by the CRM, which the HA status API now reports, instead of the mode the LRM
reports. the LRM also enters maintenance mode on shutdown with the 'migrate'
shutdown policy, which a disable request cannot undo

the UI patch (2/4) depends on the pve-ha-manager patch (3/4), as it uses the
maintenance request reported by the HA status API, so pve-manager needs a
bumped dependency on pve-ha-manager

basic functionality was tested in a virtualized 3-node cluster:
* enabling/disabling worked as expected
* possible actions were offered as expected

changes since v3:
* rebase onto current master, including the arm/disarm changes, which also
  added a toolbar to the HA status panel
* ha-manager: report the CRM maintenance request instead of the LRM mode
* manager: api: check Sys.Modify on /nodes/{node} instead of /, reject nodes
  unknown to HA, and reject enabling maintenance while HA is disarmed or if the
  node is not online
* manager: ui: move the menu next to Arm/Disarm, use the view model and
  controller of the HA status panel, fix selection handling, use complete
  sentences for translatable strings, show a spinner while a maintenance request
  is processed
* docs: condense the UI instructions and adapt them to the menu

[0] https://lore.proxmox.com/all/20251025183814.698627-1-thomas@atskinner.net/


pve-manager:

Dominik Rusovac (2):
  api: nodes: add endpoint to set maintenance mode
  fix #6144: ui: ha: status: allow toggling maintenance mode

 PVE/API2/Nodes.pm             |  54 ++++++++++++++++++
 www/manager6/ha/Status.js     | 102 ++++++++++++++++++++++++++++++++++
 www/manager6/ha/StatusView.js |  36 +++++++++++-
 3 files changed, 191 insertions(+), 1 deletion(-)


pve-ha-manager:

Dominik Rusovac (1):
  api: status: report node maintenance request for lrm entries

 src/PVE/API2/HA/Status.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)


pve-docs:

Dominik Rusovac (1):
  ha-manager: maintenance mode: mention web ui menu

 ha-manager.adoc | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)


Summary over all repositories:
  5 files changed, 210 insertions(+), 7 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-11-13 15:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:26 Dominik Rusovac [this message]
2026-11-13 15:26 ` [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set maintenance mode Dominik Rusovac
2026-11-16 11:57   ` Daniel Kral
2026-11-17  8:58     ` Dominik Rusovac
2026-11-17  9:21       ` Daniel Kral
2026-11-17  9:40         ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-manager v4 2/4] fix #6144: ui: ha: status: allow toggling " Dominik Rusovac
2026-11-17  9:07   ` Daniel Kral
2026-11-17 11:02     ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-ha-manager v4 3/4] api: status: report node maintenance request for lrm entries Dominik Rusovac
2026-11-16 12:02   ` Daniel Kral
2026-11-13 15:26 ` [PATCH pve-docs v4 4/4] ha-manager: maintenance mode: mention web ui menu Dominik Rusovac
2026-11-19 10:05 ` [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113152620.2662417-1-d.rusovac@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal