From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Cc: Thomas Skinner <thomas@atskinner.net>
Subject: Re: [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set maintenance mode
Date: Tue, 17 Nov 2026 10:40:33 +0100 [thread overview]
Message-ID: <DMXDXR221D03.30Z5PBLA663ZO@proxmox.com> (raw)
In-Reply-To: <DMXDJHVJY3RX.2W60XCEFCZTHN@proxmox.com>
On Tue Nov 17, 2026 at 10:21 AM CET, Daniel Kral wrote:
> On Tue Nov 17, 2026 at 9:58 AM CET, Dominik Rusovac wrote:
>> thx for the review, will send a v5
>>
>> On Mon Nov 16, 2026 at 12:57 PM CET, Daniel Kral wrote:
>>> On Fri Nov 13, 2026 at 4:26 PM CET, Dominik Rusovac wrote:
>>>
>>> A PVE::Tools::run_command() would be enough here AFAICT, because if it
>>> fails then we just fail here as well and forward the error message.
>>>
>>
>> I will write a dedicated wrapper that queues a request to enable/disable
>> maintenance
>
> Hm, run_command() might be a better separation here.
ack, will use run_command()
[snip]
next prev parent reply other threads:[~2026-11-17 9:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 15:26 [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-manager v4 1/4] api: nodes: add endpoint to set " Dominik Rusovac
2026-11-16 11:57 ` Daniel Kral
2026-11-17 8:58 ` Dominik Rusovac
2026-11-17 9:21 ` Daniel Kral
2026-11-17 9:40 ` Dominik Rusovac [this message]
2026-11-13 15:26 ` [PATCH pve-manager v4 2/4] fix #6144: ui: ha: status: allow toggling " Dominik Rusovac
2026-11-17 9:07 ` Daniel Kral
2026-11-17 11:02 ` Dominik Rusovac
2026-11-13 15:26 ` [PATCH pve-ha-manager v4 3/4] api: status: report node maintenance request for lrm entries Dominik Rusovac
2026-11-16 12:02 ` Daniel Kral
2026-11-13 15:26 ` [PATCH pve-docs v4 4/4] ha-manager: maintenance mode: mention web ui menu Dominik Rusovac
2026-11-19 10:05 ` [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMXDXR221D03.30Z5PBLA663ZO@proxmox.com \
--to=d.rusovac@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=thomas@atskinner.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox