Re: [PATCH qemu-server v2 7/7] clone disk: bump timeout for querying volume sizes to 1 minute

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

I like the additional verbosity, but I feel like this should belong 
in logs with log level = DEBUG. But that would require a big upgrade to
our logging system. So this change LGTM for now!

side note: We seem to have a lot of hard-coded timeout values in this
repo. Perhaps we should consider parameterizing them somehow, e.g. to
make them configureable by advanced users.

Just my thoughts, doesn't effect this review, consider this:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Thu Oct 29, 2026 at 1:06 PM CET, Fiona Ebner wrote:
> Since commit "fix #8209: clone disk: do not ignore failure to query
> size of target", failure to query the size of the target volume after
> clone is no longer quietly ignored. Bump the timeout to reduce the
> likelihood of harmless timeouts causing a warning. Print a message to
> communicate that the query is happening to the user.
>
> For consistency, also bump the timeout when querying the source
> volume. Clone might involve multiple disks and it could be a lot of
> wasted work if the whole operation is aborted because of reaching the
> timeout when querying the size.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v2:
> * Use 'clone' in log message for consistency and triple dots.
> * Also bump timeout for querying source volumes.
>
>  src/PVE/QemuServer.pm | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index 636a5602..e1a0ad2f 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -7945,13 +7945,15 @@ sub clone_disk {
>          } elsif ($dst_drivename eq 'efidisk0') {
>              $size = $efisize or die "internal error - need to specify EFI disk size\n";
>          } elsif ($dst_drivename eq 'tpmstate0') {
> -            $size = get_tpmstate_size($drive->{file}, $storecfg);
> +            print "querying size of source volume '$drive->{file}'...\n";
> +            $size = get_tpmstate_size($drive->{file}, $storecfg, 60);
>          } else {
>              clone_disk_check_io_uring(
>                  $vmid, $drive, $storecfg, $src_storeid, $storeid, $use_drive_mirror,
>              );
>  
> -            $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 10);
> +            print "querying size of source volume '$drive->{file}'...\n";
> +            $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 60);
>              die "unable to query size of volume '$drive->{file}'\n" if !$size;
>          }
>          $source->{size} = $size;
> @@ -7988,7 +7990,8 @@ sub clone_disk {
>      }
>  
>      my $result = {};
> -    my $size = eval { PVE::Storage::volume_size_info($storecfg, $newvolid, 10) };
> +    print "querying size of target volume '$newvolid' after clone...\n";
> +    my $size = eval { PVE::Storage::volume_size_info($storecfg, $newvolid, 60) };
>      my $err = $@;
>      $err = "no size in result" if !$err && !$size;
>      if ($err) {