Re: [PATCH qemu-server v2 6/7] drive: get tpm state size: add timeout parameter

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

LGTM!

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Thu Oct 29, 2026 at 1:06 PM CET, Fiona Ebner wrote:
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
>  src/PVE/QemuServer/Drive.pm | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
> index 7b288e78..951b7bb6 100644
> --- a/src/PVE/QemuServer/Drive.pm
> +++ b/src/PVE/QemuServer/Drive.pm
> @@ -1323,9 +1323,12 @@ sub update_tpmstate_size {
>  
>  # Takes in a volume id and the storage configuration. Will then try to find
>  # the actual storage size of the TPM drive. The final value has a minimum
> -# determined by the TPMSTATE_DISK_SIZE static, which is 4MiB.
> +# determined by the TPMSTATE_DISK_SIZE static, which is 4MiB. The default
> +# timeout is 10 seconds and can be changed via the $timeout parameter.
>  sub get_tpmstate_size {
> -    my ($volid, $storecfg) = @_;
> +    my ($volid, $storecfg, $timeout) = @_;
> +
> +    $timeout = 10 if !defined($timeout);
>  
>      die "a volume id has to be supplied to determine tpm state size"
>          if !defined($volid);
> @@ -1333,7 +1336,7 @@ sub get_tpmstate_size {
>      die "the storage config has to be supplied to determine tpm state size"
>          if !defined($storecfg);
>  
> -    my $size = eval { PVE::Storage::volume_size_info($storecfg, $volid, 10) };
> +    my $size = eval { PVE::Storage::volume_size_info($storecfg, $volid, $timeout) };
>      my $err = $@;
>      $err = "no size in result" if !$err && !$size;
>      warn "failed to get size of the tpm drive $volid: $err" if $err;