From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 61C8D1FF0B7 for ; Fri, 30 Oct 2026 12:02:12 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 24FD02146C; Fri, 30 Oct 2026 12:02:09 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 30 Oct 2026 12:02:04 +0100 Message-Id: Subject: Re: [PATCH qemu-server v2 6/7] drive: get tpm state size: add timeout parameter From: "Elias Huhsovitz" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20261029120811.107814-1-f.ebner@proxmox.com> <20261029120811.107814-7-f.ebner@proxmox.com> In-Reply-To: <20261029120811.107814-7-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793358124878 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.468 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I3ZMXXYEZ5E2XMFOBSIHH7ALRVHREDDB X-Message-ID-Hash: I3ZMXXYEZ5E2XMFOBSIHH7ALRVHREDDB X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: LGTM! Reviewed-by: Elias Huhsovitz On Thu Oct 29, 2026 at 1:06 PM CET, Fiona Ebner wrote: > Signed-off-by: Fiona Ebner > --- > > New in v2. > > src/PVE/QemuServer/Drive.pm | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm > index 7b288e78..951b7bb6 100644 > --- a/src/PVE/QemuServer/Drive.pm > +++ b/src/PVE/QemuServer/Drive.pm > @@ -1323,9 +1323,12 @@ sub update_tpmstate_size { > =20 > # Takes in a volume id and the storage configuration. Will then try to f= ind > # the actual storage size of the TPM drive. The final value has a minimu= m > -# determined by the TPMSTATE_DISK_SIZE static, which is 4MiB. > +# determined by the TPMSTATE_DISK_SIZE static, which is 4MiB. The defaul= t > +# timeout is 10 seconds and can be changed via the $timeout parameter. > sub get_tpmstate_size { > - my ($volid, $storecfg) =3D @_; > + my ($volid, $storecfg, $timeout) =3D @_; > + > + $timeout =3D 10 if !defined($timeout); > =20 > die "a volume id has to be supplied to determine tpm state size" > if !defined($volid); > @@ -1333,7 +1336,7 @@ sub get_tpmstate_size { > die "the storage config has to be supplied to determine tpm state si= ze" > if !defined($storecfg); > =20 > - my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $volid= , 10) }; > + my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $volid= , $timeout) }; > my $err =3D $@; > $err =3D "no size in result" if !$err && !$size; > warn "failed to get size of the tpm drive $volid: $err" if $err;