[PATCH qemu-server v2 5/7] clone disk: abort early when failing to query size of source disk

[Fiona Ebner <f.ebner@proxmox.com>]

Not all plugin implementations of the volume_size_info() method fail
if there is an error. In particular, the native file-based plugins
use file_size_info() which returns undef upon failure.

While clone is likely to fail later (e.g. vdisk_alloc() is called with
an undef size), avoid any surprises and fail early with a clean error.

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

No changes in v2.

 src/PVE/QemuServer.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index d92b2e95..636a5602 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -7952,6 +7952,7 @@ sub clone_disk {
             );
 
             $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 10);
+            die "unable to query size of volume '$drive->{file}'\n" if !$size;
         }
         $source->{size} = $size;
         $newvolid = PVE::Storage::vdisk_alloc(
-- 
2.47.3