From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BF1691FF0BC for ; Thu, 29 Oct 2026 13:08:45 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F3C342160C; Thu, 29 Oct 2026 13:08:26 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 5/7] clone disk: abort early when failing to query size of source disk Date: Thu, 29 Oct 2026 13:06:56 +0100 Message-ID: <20261029120811.107814-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261029120811.107814-1-f.ebner@proxmox.com> References: <20261029120811.107814-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793275701028 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.328 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QYSGURJMYFSZCZ7VOA763KUSALB44PHC X-Message-ID-Hash: QYSGURJMYFSZCZ7VOA763KUSALB44PHC X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Not all plugin implementations of the volume_size_info() method fail if there is an error. In particular, the native file-based plugins use file_size_info() which returns undef upon failure. While clone is likely to fail later (e.g. vdisk_alloc() is called with an undef size), avoid any surprises and fail early with a clean error. Reviewed-by: Elias Huhsovitz Signed-off-by: Fiona Ebner --- No changes in v2. src/PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index d92b2e95..636a5602 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7952,6 +7952,7 @@ sub clone_disk { ); $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 10); + die "unable to query size of volume '$drive->{file}'\n" if !$size; } $source->{size} = $size; $newvolid = PVE::Storage::vdisk_alloc( -- 2.47.3