Re: [PATCH qemu-server v2 2/7] drive: get tpm state size: also warn if there was no size returned

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

More specific error messages make debugging easier, so consider this:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Thu Oct 29, 2026 at 1:06 PM CET, Fiona Ebner wrote:
> Some storage plugin implementations of the volume_size_info() method
> do not fail with a hard error. In particular, the native file-based
> plugins use file_size_info() which returns undef upon failure. Thus,
> explicitly check the size.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
>  src/PVE/QemuServer/Drive.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
> index 0ca3d636..7b288e78 100644
> --- a/src/PVE/QemuServer/Drive.pm
> +++ b/src/PVE/QemuServer/Drive.pm
> @@ -1334,7 +1334,9 @@ sub get_tpmstate_size {
>          if !defined($storecfg);
>  
>      my $size = eval { PVE::Storage::volume_size_info($storecfg, $volid, 10) };
> -    warn "failed to get size of the tpm drive $volid: $@" if $@;
> +    my $err = $@;
> +    $err = "no size in result" if !$err && !$size;
> +    warn "failed to get size of the tpm drive $volid: $err" if $err;
>  
>      if (!$size || $size < TPMSTATE_DISK_SIZE) {
>          $size = TPMSTATE_DISK_SIZE;