From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id E4F871FF0B7
	for <inbox@lore.proxmox.com>; Fri, 30 Oct 2026 11:39:37 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 4EC5021501;
	Fri, 30 Oct 2026 11:39:36 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 30 Oct 2026 11:39:32 +0100
Message-Id: <DMI3X3QFQ3KT.3OJO6PPOODTJR@proxmox.com>
Subject: Re: [PATCH qemu-server v2 2/7] drive: get tpm state size: also warn
 if there was no size returned
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>, <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.20.0
References: <20261029120811.107814-1-f.ebner@proxmox.com>
 <20261029120811.107814-3-f.ebner@proxmox.com>
In-Reply-To: <20261029120811.107814-3-f.ebner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793356772419
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.474 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: PUJZIF3KFTFXQ6WNHLGV3R54DHTKIUAS
X-Message-ID-Hash: PUJZIF3KFTFXQ6WNHLGV3R54DHTKIUAS
X-MailFrom: e.huhsovitz@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

More specific error messages make debugging easier, so consider this:

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Thu Oct 29, 2026 at 1:06 PM CET, Fiona Ebner wrote:
> Some storage plugin implementations of the volume_size_info() method
> do not fail with a hard error. In particular, the native file-based
> plugins use file_size_info() which returns undef upon failure. Thus,
> explicitly check the size.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
>  src/PVE/QemuServer/Drive.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
> index 0ca3d636..7b288e78 100644
> --- a/src/PVE/QemuServer/Drive.pm
> +++ b/src/PVE/QemuServer/Drive.pm
> @@ -1334,7 +1334,9 @@ sub get_tpmstate_size {
>          if !defined($storecfg);
> =20
>      my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $volid=
, 10) };
> -    warn "failed to get size of the tpm drive $volid: $@" if $@;
> +    my $err =3D $@;
> +    $err =3D "no size in result" if !$err && !$size;
> +    warn "failed to get size of the tpm drive $volid: $err" if $err;
> =20
>      if (!$size || $size < TPMSTATE_DISK_SIZE) {
>          $size =3D TPMSTATE_DISK_SIZE;