From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E6D141FF0B7 for ; Fri, 30 Oct 2026 12:14:18 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 88683215F5; Fri, 30 Oct 2026 12:14:16 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 30 Oct 2026 12:14:12 +0100 Message-Id: Subject: Re: [PATCH qemu-server v2 7/7] clone disk: bump timeout for querying volume sizes to 1 minute From: "Elias Huhsovitz" To: "Fiona Ebner" , X-Mailer: aerc 0.20.0 References: <20261029120811.107814-1-f.ebner@proxmox.com> <20261029120811.107814-8-f.ebner@proxmox.com> In-Reply-To: <20261029120811.107814-8-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793358852310 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.466 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XSDTZHSPV4ZA6JOS6KRMTZBJZR33AM6R X-Message-ID-Hash: XSDTZHSPV4ZA6JOS6KRMTZBJZR33AM6R X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I like the additional verbosity, but I feel like this should belong=20 in logs with log level =3D DEBUG. But that would require a big upgrade to our logging system. So this change LGTM for now! side note: We seem to have a lot of hard-coded timeout values in this repo. Perhaps we should consider parameterizing them somehow, e.g. to make them configureable by advanced users. Just my thoughts, doesn't effect this review, consider this: Reviewed-by: Elias Huhsovitz On Thu Oct 29, 2026 at 1:06 PM CET, Fiona Ebner wrote: > Since commit "fix #8209: clone disk: do not ignore failure to query > size of target", failure to query the size of the target volume after > clone is no longer quietly ignored. Bump the timeout to reduce the > likelihood of harmless timeouts causing a warning. Print a message to > communicate that the query is happening to the user. > > For consistency, also bump the timeout when querying the source > volume. Clone might involve multiple disks and it could be a lot of > wasted work if the whole operation is aborted because of reaching the > timeout when querying the size. > > Signed-off-by: Fiona Ebner > --- > > Changes in v2: > * Use 'clone' in log message for consistency and triple dots. > * Also bump timeout for querying source volumes. > > src/PVE/QemuServer.pm | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index 636a5602..e1a0ad2f 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -7945,13 +7945,15 @@ sub clone_disk { > } elsif ($dst_drivename eq 'efidisk0') { > $size =3D $efisize or die "internal error - need to specify = EFI disk size\n"; > } elsif ($dst_drivename eq 'tpmstate0') { > - $size =3D get_tpmstate_size($drive->{file}, $storecfg); > + print "querying size of source volume '$drive->{file}'...\n"= ; > + $size =3D get_tpmstate_size($drive->{file}, $storecfg, 60); > } else { > clone_disk_check_io_uring( > $vmid, $drive, $storecfg, $src_storeid, $storeid, $use_d= rive_mirror, > ); > =20 > - $size =3D PVE::Storage::volume_size_info($storecfg, $drive->= {file}, 10); > + print "querying size of source volume '$drive->{file}'...\n"= ; > + $size =3D PVE::Storage::volume_size_info($storecfg, $drive->= {file}, 60); > die "unable to query size of volume '$drive->{file}'\n" if != $size; > } > $source->{size} =3D $size; > @@ -7988,7 +7990,8 @@ sub clone_disk { > } > =20 > my $result =3D {}; > - my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $newvo= lid, 10) }; > + print "querying size of target volume '$newvolid' after clone...\n"; > + my $size =3D eval { PVE::Storage::volume_size_info($storecfg, $newvo= lid, 60) }; > my $err =3D $@; > $err =3D "no size in result" if !$err && !$size; > if ($err) {