Re: [PATCH login-manager v3 3/5] refactor: ui: split password form into its own widget

["Shan Shaji" <s.shaji@proxmox.com>]

On Fri Aug 21, 2026 at 5:41 AM CEST, Azharul Haque wrote:

[snip]

> +
> +/// Username/password credential fields of the login form, including the
> +/// optional "save password" checkbox.
> +class _ProxmoxPasswordForm extends StatefulWidget {
> +  final TextEditingController usernameController;
> +  final TextEditingController passwordController;
> +  final Function? onPasswordSubmitted;
> +  final Function? onSavePasswordChanged;
> +  final bool? canSavePassword;
> +  final bool? passwordSaved;
> +
> +  const _ProxmoxPasswordForm({
> +    required this.usernameController,
> +    required this.passwordController,
> +    this.onPasswordSubmitted,
> +    this.onSavePasswordChanged,
> +    this.canSavePassword,
> +    this.passwordSaved,
> +  });
> +
> +  @override
> +  State<_ProxmoxPasswordForm> createState() => _ProxmoxPasswordFormState();
> +}
> +
> +class _ProxmoxPasswordFormState extends State<_ProxmoxPasswordForm> {
> +  bool _obscure = true;
> +  bool? _savePwCheckbox;
> +  FocusNode? passwordFocusNode;

nit: I believe the FocusNode is implicitly initialized to null. It's not
instantiated and null is assigned to the TextFormField. You don't
need to  do anything as it's  same in master as well. I just want to
note it here.  Will fix it in another patch.

> +  @override
> +  Widget build(BuildContext context) {
> +    return Column(
> +      mainAxisSize: MainAxisSize.min,
> +      children: [
> +        TextFormField(
> +          decoration: const InputDecoration(
> +            icon: Icon(Icons.person),
> +            labelText: 'Username',
> +          ),
> +          controller: widget.usernameController,
> +          validator: (value) {
> +            if (value!.isEmpty) {
> +              return 'Please enter username';
> +            }
> +            return null;
> +          },
> +          autofillHints: const [AutofillHints.username],
> +        ),
> +        Stack(
> +          children: [
> +            TextFormField(
> +              decoration: const InputDecoration(
> +                icon: Icon(Icons.lock),
> +                labelText: 'Password',
> +              ),
> +              controller: widget.passwordController,
> +              obscureText: _obscure,
> +              autocorrect: false,
> +              focusNode: passwordFocusNode,
> +              validator: (value) {
> +                if (value!.isEmpty) {
> +                  return 'Please enter password';
>                  }
> -                setState(() {
> -                  _savePwCheckbox = value!;
> -                });
> +                return null;
>                },
> +              onFieldSubmitted: (value) => widget.onPasswordSubmitted!(),
> +              autofillHints: const [AutofillHints.password],
> +            ),

[snip]