Re: [PATCH 0/2] android: register OpenID Connect callback activity for #4281

["Shan Shaji" <s.shaji@proxmox.com>]

Hi Azharul,

Thank you so much for your patches. If you are sending patches for the
first time and haven't yet had the chance to fill out our CLA. Please
check this: https://proxmox.com/en/about/open-source/developers

Right now, AFAICT, you have sent series for each repository seperately:

- android: register OpenID Connect callback activity for #4281 (pve_flutter_frontend)
- ui: implement OpenID Connect login flow for #4281 (proxmox_login_manager)
- add OpenID Connect support for #4281 (proxmox_dart_api_client)

Instead of sending the changes seperately as different series. Please
send them as a single series including the repository name inside the patch
subject prefix [0]. It would be really helpful for us when testing and
reviewing the changes. Thus reducing the noise on mailling list as well. 

- [0] https://pve.proxmox.com/wiki/Developer_Documentation#Preparing_Patches

On Mon Aug 10, 2026 at 7:40 AM CEST, Azharul Haque wrote:
> The native Flutter "Proxmox VE Companion" app never implemented OpenID
> Connect / OAuth realm login (bug #4281[0]): selecting an OAuth realm
> just showed username/password fields that could never work.
>
> Android requires an app to explicitly declare, in AndroidManifest.xml,
> which activity should handle a given custom URL scheme. This series
> registers flutter_web_auth_2's CallbackActivity for the
> com.proxmox.app.openid:// redirect scheme used by the OAuth flow, and
> fixes it up to match a later rename of that scheme.
>
> No iOS-side changes are needed: ASWebAuthenticationSession resolves
> the custom-scheme redirect at runtime without a static declaration
> equivalent to this manifest entry.
>
> Depends on the companion proxmox_dart_api_client and
> proxmox_login_manager series, which implement the OIDC API calls and
> login-form/OAuth-flow UI respectively.
>
> Verified end-to-end against a real PVE server with an Authentik OIDC
> realm, on both Android and iOS.
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4281
>
> Azharul Haque (2):
>   fix #4281: android: register OpenID Connect callback activity
>   fix #4281: android: match renamed OpenID callback scheme
>
>  android/app/src/main/AndroidManifest.xml     |  16 ++
>  linux/flutter/generated_plugin_registrant.cc |   8 +
>  linux/flutter/generated_plugins.cmake        |   2 +
>  pubspec.lock                                 | 184 +++++++++++--------
>  4 files changed, 138 insertions(+), 72 deletions(-)