From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 217BD1FF0E1 for ; Mon, 10 Aug 2026 15:59:42 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 57EC42173E; Mon, 10 Aug 2026 15:59:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 10 Aug 2026 15:59:37 +0200 Message-Id: Subject: Re: [PATCH 0/2] android: register OpenID Connect callback activity for #4281 From: "Shan Shaji" To: "Azharul Haque" , X-Mailer: aerc 0.20.0 References: <20260810054037.17184-1-haque@azharul.com> In-Reply-To: <20260810054037.17184-1-haque@azharul.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786370365808 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.904 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3KTMWP6YN5SB7Z6S7XW5ZXB55TSWDX6L X-Message-ID-Hash: 3KTMWP6YN5SB7Z6S7XW5ZXB55TSWDX6L X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Azharul, Thank you so much for your patches. If you are sending patches for the first time and haven't yet had the chance to fill out our CLA. Please check this: https://proxmox.com/en/about/open-source/developers Right now, AFAICT, you have sent series for each repository seperately: - android: register OpenID Connect callback activity for #4281 (pve_flutter= _frontend) - ui: implement OpenID Connect login flow for #4281 (proxmox_login_manager) - add OpenID Connect support for #4281 (proxmox_dart_api_client) Instead of sending the changes seperately as different series. Please send them as a single series including the repository name inside the patch subject prefix [0]. It would be really helpful for us when testing and reviewing the changes. Thus reducing the noise on mailling list as well.=20 - [0] https://pve.proxmox.com/wiki/Developer_Documentation#Preparing_Patche= s On Mon Aug 10, 2026 at 7:40 AM CEST, Azharul Haque wrote: > The native Flutter "Proxmox VE Companion" app never implemented OpenID > Connect / OAuth realm login (bug #4281[0]): selecting an OAuth realm > just showed username/password fields that could never work. > > Android requires an app to explicitly declare, in AndroidManifest.xml, > which activity should handle a given custom URL scheme. This series > registers flutter_web_auth_2's CallbackActivity for the > com.proxmox.app.openid:// redirect scheme used by the OAuth flow, and > fixes it up to match a later rename of that scheme. > > No iOS-side changes are needed: ASWebAuthenticationSession resolves > the custom-scheme redirect at runtime without a static declaration > equivalent to this manifest entry. > > Depends on the companion proxmox_dart_api_client and > proxmox_login_manager series, which implement the OIDC API calls and > login-form/OAuth-flow UI respectively. > > Verified end-to-end against a real PVE server with an Authentik OIDC > realm, on both Android and iOS. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3D4281 > > Azharul Haque (2): > fix #4281: android: register OpenID Connect callback activity > fix #4281: android: match renamed OpenID callback scheme > > android/app/src/main/AndroidManifest.xml | 16 ++ > linux/flutter/generated_plugin_registrant.cc | 8 + > linux/flutter/generated_plugins.cmake | 2 + > pubspec.lock | 184 +++++++++++-------- > 4 files changed, 138 insertions(+), 72 deletions(-)