[PATCH login-manager v3 2/5] refactor: ui: factor out shared login tail into _finishLogin

[Azharul Haque <haque@azharul.com>]

Move the code that runs after an authenticated API client exists --
handling a pending TFA challenge, fetching cluster status, persisting
the login and closing the login page -- out of _onLoginButtonPressed
into a _finishLogin method. No functional change.

This prepares for the OpenID Connect login flow added in a following
commit, which obtains its client through a browser-based flow instead
of a password but finishes the login the same way.

Suggested-by: Shan Shaji <s.shaji@proxmox.com>
Signed-off-by: Azharul Haque <haque@azharul.com>
---
 lib/proxmox_login_form.dart | 203 ++++++++++++++++++++----------------
 1 file changed, 111 insertions(+), 92 deletions(-)

diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index 5b9a64e..6039407 100644
--- a/lib/proxmox_login_form.dart
+++ b/lib/proxmox_login_form.dart
@@ -478,98 +478,13 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
       var client = await proxclient.authenticate(
           '$username@$realm', password, origin, settings.sslValidation!);
 
-      if (client.credentials.tfa != null &&
-          client.credentials.tfa!.kinds().isNotEmpty) {
-        if (!mounted) return;
-        ProxmoxApiClient? tfaclient =
-            await Navigator.of(context).push(MaterialPageRoute(
-          builder: (context) => ProxmoxTfaForm(
-            apiClient: client,
-          ),
-        ));
-
-        if (tfaclient != null) {
-          client = tfaclient;
-        } else {
-          setState(() {
-            _progressModel.inProgress -= 1;
-          });
-          return;
-        }
-      }
-
-      final status = await client.getClusterStatus();
-      final hostname =
-          status.singleWhereOrNull((element) => element.local ?? false)?.name;
-      var loginStorage = await ProxmoxLoginStorage.fromLocalStorage();
-
-      final savePW = enteredPassword != '' &&
-          _savePasswordCB &&
-          enteredPassword != savedPassword;
-      final deletePW = enteredPassword != '' && !savePW && !_savePasswordCB;
-      String? id;
-
-      if (widget.isCreate!) {
-        final newLogin = ProxmoxLoginModel((b) => b
-          ..origin = origin
-          ..username = username
-          ..realm = realm
-          ..productType = ProxmoxProductType.pve
-          ..ticket = client.credentials.ticket
-          ..passwordSaved = savePW
-          ..hostname = hostname);
-
-        loginStorage = loginStorage!.rebuild((b) => b..logins.add(newLogin));
-        id = newLogin.identifier;
-      } else {
-        loginStorage = loginStorage!.rebuild((b) => b
-          ..logins.rebuildWhere(
-              (m) => m == widget.userModel,
-              (b) => b
-                ..ticket = client.credentials.ticket
-                ..passwordSaved =
-                    savePW || (deletePW ? false : b.passwordSaved ?? false)
-                ..hostname = hostname));
-        id = widget.userModel!.identifier;
-      }
-
-      if (id != null) {
-        try {
-          if (savePW) {
-            await savePassword(id, enteredPassword);
-          } else if (deletePW) {
-            await deletePassword(id);
-          }
-        } catch (e) {
-          if (!mounted) return;
-          await showDialog(
-              context: context,
-              builder: (context) => AlertDialog(
-                    title: const Text('Password saving error'),
-                    scrollable: true,
-                    content: Column(
-                      mainAxisSize: MainAxisSize.min,
-                      children: [
-                        const Text('Could not save or delete password.'),
-                        ExpansionTile(
-                          title: const Text('Details'),
-                          children: [Text(e.toString())],
-                        )
-                      ],
-                    ),
-                    actions: [
-                      TextButton(
-                          onPressed: () => Navigator.of(context).pop(),
-                          child: const Text('Continue')),
-                    ],
-                  ));
-        }
-      }
-      await loginStorage.saveToDisk();
-
-      if (mounted) {
-        Navigator.of(context).pop(client);
-      }
+      await _finishLogin(
+        client,
+        realm: realm!,
+        username: username,
+        enteredPassword: enteredPassword,
+        savedPassword: savedPassword,
+      );
     } on proxclient.ProxmoxApiException catch (e) {
       print(e);
       if (!mounted) return;
@@ -618,6 +533,110 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
     });
   }
 
+  /// Common tail of the login flow once an authenticated client exists:
+  /// handles a pending TFA challenge, fetches cluster status, persists the
+  /// login and closes the login page. Returns early (without closing the
+  /// page) if the user cancels a TFA challenge.
+  Future<void> _finishLogin(
+    ProxmoxApiClient client, {
+    required String realm,
+    required String username,
+    String enteredPassword = '',
+    String? savedPassword,
+  }) async {
+    if (client.credentials.tfa != null &&
+        client.credentials.tfa!.kinds().isNotEmpty) {
+      if (!mounted) return;
+      ProxmoxApiClient? tfaclient =
+          await Navigator.of(context).push(MaterialPageRoute(
+        builder: (context) => ProxmoxTfaForm(
+          apiClient: client,
+        ),
+      ));
+
+      if (tfaclient != null) {
+        client = tfaclient;
+      } else {
+        return;
+      }
+    }
+
+    final status = await client.getClusterStatus();
+    final hostname =
+        status.singleWhereOrNull((element) => element.local ?? false)?.name;
+    var loginStorage = await ProxmoxLoginStorage.fromLocalStorage();
+
+    final savePW = enteredPassword != '' &&
+        _savePasswordCB &&
+        enteredPassword != savedPassword;
+    final deletePW = enteredPassword != '' && !savePW && !_savePasswordCB;
+    String? id;
+
+    final origin = normalizeUrl(_originController.text.trim());
+
+    if (widget.isCreate!) {
+      final newLogin = ProxmoxLoginModel((b) => b
+        ..origin = origin
+        ..username = username
+        ..realm = realm
+        ..productType = ProxmoxProductType.pve
+        ..ticket = client.credentials.ticket
+        ..passwordSaved = savePW
+        ..hostname = hostname);
+
+      loginStorage = loginStorage!.rebuild((b) => b..logins.add(newLogin));
+      id = newLogin.identifier;
+    } else {
+      loginStorage = loginStorage!.rebuild((b) => b
+        ..logins.rebuildWhere(
+            (m) => m == widget.userModel,
+            (b) => b
+              ..ticket = client.credentials.ticket
+              ..passwordSaved =
+                  savePW || (deletePW ? false : b.passwordSaved ?? false)
+              ..hostname = hostname));
+      id = widget.userModel!.identifier;
+    }
+
+    if (id != null) {
+      try {
+        if (savePW) {
+          await savePassword(id, enteredPassword);
+        } else if (deletePW) {
+          await deletePassword(id);
+        }
+      } catch (e) {
+        if (!mounted) return;
+        await showDialog(
+            context: context,
+            builder: (context) => AlertDialog(
+                  title: const Text('Password saving error'),
+                  scrollable: true,
+                  content: Column(
+                    mainAxisSize: MainAxisSize.min,
+                    children: [
+                      const Text('Could not save or delete password.'),
+                      ExpansionTile(
+                        title: const Text('Details'),
+                        children: [Text(e.toString())],
+                      )
+                    ],
+                  ),
+                  actions: [
+                    TextButton(
+                        onPressed: () => Navigator.of(context).pop(),
+                        child: const Text('Continue')),
+                  ],
+                ));
+      }
+    }
+    await loginStorage.saveToDisk();
+
+    if (mounted) {
+      Navigator.of(context).pop(client);
+    }
+  }
+
   Future<List<PveAccessDomainModel?>?> _loadAccessDomains(Uri uri) async {
     final settings = await ProxmoxGeneralSettingsModel.fromLocalStorage();
     List<PveAccessDomainModel?>? response;
-- 
2.50.1 (Apple Git-155)