public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Azharul Haque" <haque@azharul.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH login-manager v2 3/3] fix #4281: ui: use a namespaced OpenID callback scheme
Date: Thu, 20 Aug 2026 16:28:55 +0200	[thread overview]
Message-ID: <DKTUC1S0U5RW.3C93881LZ0ZER@proxmox.com> (raw)
In-Reply-To: <20260810144713.75806-6-haque@azharul.com>

On Mon Aug 10, 2026 at 4:47 PM CEST, Azharul Haque wrote:
> pveauth:// worked in testing, but on Android a custom URL scheme
> isn't exclusively owned the way a verified App Link is: any other
> app installed on the device could in principle also declare an
> intent-filter for the same short, guessable scheme.
>
> Use com.proxmox.app.openid instead, derived from the app's own
> package/bundle identifier (com.proxmox.*, reserved for Proxmox on
> both app stores), so collisions with another app's scheme are
> effectively ruled out rather than merely unlikely.
>
> Signed-off-by: Azharul Haque <haque@azharul.com>
> ---
>  lib/proxmox_login_form.dart | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
> index 002838c..c5ea090 100644
> --- a/lib/proxmox_login_form.dart
> +++ b/lib/proxmox_login_form.dart
> @@ -17,7 +17,11 @@ import 'package:proxmox_login_manager/proxmox_password_store.dart';
>  /// OpenID Connect login completes. Must be registered as a valid redirect
>  /// URI with the realm's provider, as well as in the platform manifests
>  /// (AndroidManifest.xml / Info.plist).
> -const String openIdCallbackScheme = 'pveauth';
> +///
> +/// Derived from the app's own package/bundle identifier (`com.proxmox.*`,
> +/// reserved for Proxmox on both app stores) rather than an arbitrary word,
> +/// so it can't collide with another app's custom URL scheme.
> +const String openIdCallbackScheme = 'com.proxmox.app.openid';

Also, IMHO the scheme could just be (com.proxmox.app). I don't think
it has to be specific for openid. Sorry, missed to mention this in the
earlier replies. 
  
>  class ProxmoxProgressModel {
>    int inProgress = 0;





  reply	other threads:[~2026-08-20 14:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  5:40 [PATCH 0/2] android: register OpenID Connect callback activity for #4281 Azharul Haque
2026-08-10  5:40 ` [PATCH 1/2] fix #4281: android: register OpenID Connect callback activity Azharul Haque
2026-08-10  5:40 ` [PATCH 2/2] fix #4281: android: match renamed OpenID callback scheme Azharul Haque
2026-08-10 13:59 ` [PATCH 0/2] android: register OpenID Connect callback activity for #4281 Shan Shaji
2026-08-10 14:47   ` [PATCH v2 0/7] app: implement OpenID Connect (OAuth) realm login (#4281) Azharul Haque
2026-08-10 14:47     ` [PATCH dart-api-client v2 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel` Azharul Haque
2026-08-20  9:17       ` Shan Shaji
     [not found]         ` <CAFCWXbiQxG4p2U+beMjSi7Gaz5qC-vCzXW1AH3Ys-ApOW0S83w@mail.gmail.com>
2026-08-20 14:39           ` Shan Shaji
     [not found]             ` <CAFCWXbhnW0o1VcUimwk6pUB3VqCaQw31BQpuHjDtKF8LGeB-fg@mail.gmail.com>
2026-08-21  8:00               ` Shan Shaji
2026-08-10 14:47     ` [PATCH dart-api-client v2 2/2] fix #4281: access: add OpenID Connect auth-url/login helpers Azharul Haque
2026-08-20  9:48       ` Shan Shaji
2026-08-10 14:47     ` [PATCH login-manager v2 1/3] fix #4281: ui: add OpenID Connect login flow to login form Azharul Haque
2026-08-20 12:31       ` Shan Shaji
2026-08-10 14:47     ` [PATCH login-manager v2 2/3] fix #4281: ui: fix stale Continue button state on realm switch Azharul Haque
2026-08-10 14:47     ` [PATCH login-manager v2 3/3] fix #4281: ui: use a namespaced OpenID callback scheme Azharul Haque
2026-08-20 14:28       ` Shan Shaji [this message]
2026-08-10 14:47     ` [PATCH flutter-frontend v2 1/2] fix #4281: android: register OpenID Connect callback activity Azharul Haque
2026-08-20 14:01       ` Shan Shaji
2026-08-10 14:47     ` [PATCH flutter-frontend v2 2/2] fix #4281: android: match renamed OpenID callback scheme Azharul Haque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKTUC1S0U5RW.3C93881LZ0ZER@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=haque@azharul.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal