From: Azharul Haque <haque@azharul.com>
To: pve-devel@lists.proxmox.com
Cc: haque@azharul.com
Subject: [PATCH v3 00/10] app: implement OpenID Connect (OAuth) realm login (#4281)
Date: Thu, 20 Aug 2026 23:41:37 -0400 [thread overview]
Message-ID: <20260821034147.30194-1-haque@azharul.com> (raw)
In-Reply-To: <20260810144713.75806-1-haque@azharul.com>
The native Flutter "Proxmox VE Companion" app never implemented OpenID
Connect / OAuth realm login (bug #4281[0]): selecting an OAuth realm
just showed username/password fields that could never work.
v3: addresses review feedback on v2, still as a single combined series
across the three affected repositories:
- dart-api-client: PveAccessDomainModel.type is now a built_value
EnumClass (PveAccessDomainType) instead of a plain String, and the
OpenID ticket-parsing helper's regex/dedup issue is fixed.
- login-manager: the single large "add OpenID Connect login flow"
patch is split into five, dependency, _finishLogin refactor,
password-form widget extraction, the OpenID feature itself, and
the pre-existing Continue-button fix, and print()/print(trace)
calls copied into the new OpenID error handling are removed.
- flutter-frontend: the manifest change is split into three,
generated-file regeneration, the taskAffinity tweak, and the
CallbackActivity registration itself.
- Both repos' "rename the callback scheme" follow-up patches from v2
are gone entirely: the final scheme (com.proxmox.app, further
shortened per your follow-up on the login-manager v2 3/3 patch) is
now introduced directly wherever it first appears.
- All lockfiles/generated files are regenerated against Flutter
3.41 / Dart 3.11 to match this project's toolchain, rather than
the newer local Flutter version v2 was inadvertently built with.
Verified end-to-end against a real PVE server with an Authentik OIDC
realm, on both Android and iOS, plus flutter analyze/test/format under
Flutter 3.41 across all three repos, plus a real Android Gradle build
of the modified manifest.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4281
Azharul Haque (10):
fix #4281: access: add `type` property to `PveAccessDomainModel`
fix #4281: access: add OpenID Connect auth-url/login helpers
fix #4281: deps: add flutter_web_auth_2 dependency
refactor: ui: factor out shared login tail into _finishLogin
refactor: ui: split password form into its own widget
fix #4281: ui: add OpenID Connect login flow to login form
fix #4281: ui: fix stale Continue button state on realm switch
chore: regenerate plugin registrant for flutter_web_auth_2
fix #4281: android: set taskAffinity="" on MainActivity
fix #4281: android: register OpenID Connect callback activity
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-08-25 8:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 5:40 [PATCH 0/2] android: register OpenID Connect callback activity for #4281 Azharul Haque
2026-08-10 5:40 ` [PATCH 1/2] fix #4281: android: register OpenID Connect callback activity Azharul Haque
2026-08-10 5:40 ` [PATCH 2/2] fix #4281: android: match renamed OpenID callback scheme Azharul Haque
2026-08-10 13:59 ` [PATCH 0/2] android: register OpenID Connect callback activity for #4281 Shan Shaji
2026-08-10 14:47 ` [PATCH v2 0/7] app: implement OpenID Connect (OAuth) realm login (#4281) Azharul Haque
2026-08-10 14:47 ` [PATCH dart-api-client v2 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel` Azharul Haque
2026-08-20 9:17 ` Shan Shaji
2026-08-20 13:37 ` Azharul Haque
2026-08-20 14:39 ` Shan Shaji
2026-08-21 2:56 ` Azharul Haque
2026-08-21 8:00 ` Shan Shaji
2026-08-10 14:47 ` [PATCH dart-api-client v2 2/2] fix #4281: access: add OpenID Connect auth-url/login helpers Azharul Haque
2026-08-20 9:48 ` Shan Shaji
2026-08-20 13:41 ` Azharul Haque
2026-08-10 14:47 ` [PATCH login-manager v2 1/3] fix #4281: ui: add OpenID Connect login flow to login form Azharul Haque
2026-08-20 12:31 ` Shan Shaji
2026-08-10 14:47 ` [PATCH login-manager v2 2/3] fix #4281: ui: fix stale Continue button state on realm switch Azharul Haque
2026-08-10 14:47 ` [PATCH login-manager v2 3/3] fix #4281: ui: use a namespaced OpenID callback scheme Azharul Haque
2026-08-20 14:28 ` Shan Shaji
2026-08-10 14:47 ` [PATCH flutter-frontend v2 1/2] fix #4281: android: register OpenID Connect callback activity Azharul Haque
2026-08-20 14:01 ` Shan Shaji
2026-08-10 14:47 ` [PATCH flutter-frontend v2 2/2] fix #4281: android: match renamed OpenID callback scheme Azharul Haque
2026-08-21 3:41 ` Azharul Haque [this message]
2026-08-21 3:41 ` [PATCH dart-api-client v3 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel` Azharul Haque
2026-08-21 3:41 ` [PATCH dart-api-client v3 2/2] fix #4281: access: add OpenID Connect auth-url/login helpers Azharul Haque
2026-08-21 3:41 ` [PATCH login-manager v3 1/5] fix #4281: deps: add flutter_web_auth_2 dependency Azharul Haque
2026-08-21 3:41 ` [PATCH login-manager v3 2/5] refactor: ui: factor out shared login tail into _finishLogin Azharul Haque
2026-08-21 3:41 ` [PATCH login-manager v3 3/5] refactor: ui: split password form into its own widget Azharul Haque
2026-08-21 3:41 ` [PATCH login-manager v3 4/5] fix #4281: ui: add OpenID Connect login flow to login form Azharul Haque
2026-08-21 3:41 ` [PATCH login-manager v3 5/5] fix #4281: ui: fix stale Continue button state on realm switch Azharul Haque
2026-08-21 3:41 ` [PATCH flutter-frontend v3 1/3] chore: regenerate plugin registrant for flutter_web_auth_2 Azharul Haque
2026-08-21 3:41 ` [PATCH flutter-frontend v3 2/3] fix #4281: android: set taskAffinity="" on MainActivity Azharul Haque
2026-08-21 3:41 ` [PATCH flutter-frontend v3 3/3] fix #4281: android: register OpenID Connect callback activity Azharul Haque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821034147.30194-1-haque@azharul.com \
--to=haque@azharul.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox