Re: [PATCH proxmox-widget-toolkit v2 04/10] fix #7294: css: theme: add opacity override for pool VNet icon

[David Riley <d.riley@proxmox.com>]

comments inline.

On 7/3/26 3:30 PM, Daniel Kral wrote:
> On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote:
>> Add opacity adjustments for the `fa-network-wired` icon used by pool
>> networks.
>>
>> The light/base theme lowers the icons opacity to simulate a light grey
>> color that matches other configuration elements. This override
>> restores the opacity to 1 in the dark theme so the native white SVG
>> remains clearly visible against the dark background.
>>
>> Signed-off-by: David Riley<d.riley@proxmox.com>
> existing - so not related to the series directly - but the VM and CT
> icons seem to also have lower opacity


The opacity of the VMs and CTs depends on their state.
If they are turned off they are lighter and if they are turned on the icon
turns darker. In my opinion that's actual quite neat.

I'll remove the whitespaces in v3.

> With the trailing white spaces removed:
>
> Reviewed-by: Daniel Kral<d.kral@proxmox.com>
>
>> ---
>>   src/proxmox-dark/scss/other/_icons.scss | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
>> index ad08906..3712094 100644
>> --- a/src/proxmox-dark/scss/other/_icons.scss
>> +++ b/src/proxmox-dark/scss/other/_icons.scss
>> @@ -250,3 +250,15 @@
>>   .usage {
>>     background-color: $icon-color;
>>   }
>> +
>> +// fa-network-wired override for dark mode.
>> +// The base/light theme lowers the opacity to simulate a light grey
> nit: trailing white space
>
>> +// color. This restores the opacity to 1 so the icon remains white and
>> +// clearly visible in the dark mode
> nit: trailing white space
>
>> +.x-fa-pool-net:before {
>> +   opacity: 1;
>> +}
>> +
>> +.x-fa-pool-net-grid:before {
>> +   opacity: 1;
>> +}
>