From: "Daniel Kral" <d.kral@proxmox.com>
To: "David Riley" <d.riley@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH proxmox-widget-toolkit v2 04/10] fix #7294: css: theme: add opacity override for pool VNet icon
Date: Fri, 03 Jul 2026 15:30:41 +0200 [thread overview]
Message-ID: <DJOZ1BMXC3B1.HO6YGBEJXK9H@proxmox.com> (raw)
In-Reply-To: <20260626131035.112374-5-d.riley@proxmox.com>
On Fri Jun 26, 2026 at 3:10 PM CEST, David Riley wrote:
> Add opacity adjustments for the `fa-network-wired` icon used by pool
> networks.
>
> The light/base theme lowers the icons opacity to simulate a light grey
> color that matches other configuration elements. This override
> restores the opacity to 1 in the dark theme so the native white SVG
> remains clearly visible against the dark background.
>
> Signed-off-by: David Riley <d.riley@proxmox.com>
existing - so not related to the series directly - but the VM and CT
icons seem to also have lower opacity
With the trailing white spaces removed:
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
> ---
> src/proxmox-dark/scss/other/_icons.scss | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
> index ad08906..3712094 100644
> --- a/src/proxmox-dark/scss/other/_icons.scss
> +++ b/src/proxmox-dark/scss/other/_icons.scss
> @@ -250,3 +250,15 @@
> .usage {
> background-color: $icon-color;
> }
> +
> +// fa-network-wired override for dark mode.
> +// The base/light theme lowers the opacity to simulate a light grey
nit: trailing white space
> +// color. This restores the opacity to 1 so the icon remains white and
> +// clearly visible in the dark mode
nit: trailing white space
> +.x-fa-pool-net:before {
> + opacity: 1;
> +}
> +
> +.x-fa-pool-net-grid:before {
> + opacity: 1;
> +}
next prev parent reply other threads:[~2026-07-03 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 13:10 [PATCH access-control/cluster/common/manager/network/proxmox-widget-toolkit/qemu-server v2 00/10] fix #7294: pool: add SDN VNets as pool members David Riley
2026-06-26 13:10 ` [PATCH pve-manager v2 01/10] ui: replace var with let to match style guide for variable declaration David Riley
2026-07-03 13:14 ` Daniel Kral
2026-06-26 13:10 ` [PATCH pve-manager v2 02/10] fix #7294: api: pool: add SDN VNets as pool members David Riley
2026-07-03 13:19 ` Daniel Kral
2026-06-26 13:10 ` [PATCH pve-manager v2 03/10] fix #7294: ui: " David Riley
2026-06-26 13:10 ` [PATCH proxmox-widget-toolkit v2 04/10] fix #7294: css: theme: add opacity override for pool VNet icon David Riley
2026-07-03 13:30 ` Daniel Kral [this message]
2026-06-26 13:10 ` [PATCH pve-access-control v2 05/10] fix #7294: acl: pool: add SDN VNets as pool members David Riley
2026-07-03 14:35 ` Daniel Kral
2026-06-26 13:10 ` [PATCH pve-network v2 06/10] fix #7294: sdn: register api formats for zones and vnets David Riley
2026-06-26 13:10 ` [PATCH pve-network v2 07/10] fix #7294: sdn: vnet: update pool members on vnet migration and deletion David Riley
2026-06-26 13:10 ` [PATCH pve-common v2 08/10] tools: add helpers for version comparison David Riley
2026-06-26 13:10 ` [PATCH pve-cluster v2 09/10] fix #7294: cluster: helpers: add cluster-wide version assertion David Riley
2026-06-26 13:10 ` [PATCH qemu-server v2 10/10] fix #7294: helpers: use cluster-wide version helper David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJOZ1BMXC3B1.HO6YGBEJXK9H@proxmox.com \
--to=d.kral@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox